Skip to content

Commit e0d114c

Browse files
Appease the linter by using absl::StrAppend instead of absl::StrCat
PiperOrigin-RevId: 858867581
1 parent 563f613 commit e0d114c

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

conformance/binary_json_conformance_suite.cc

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ void BinaryAndJsonConformanceSuiteImpl<MessageType>::TestValidDataForType(
947947
if (type != FieldDescriptor::TYPE_MESSAGE) {
948948
std::string proto;
949949
for (size_t i = 0; i < values.size(); i++) {
950-
proto += absl::StrCat(tag(field->number(), wire_type), values[i].first);
950+
absl::StrAppend(&proto, tag(field->number(), wire_type), values[i].first);
951951
}
952952
std::string expected_proto =
953953
absl::StrCat(tag(field->number(), wire_type), values.back().second);
@@ -979,21 +979,23 @@ void BinaryAndJsonConformanceSuiteImpl<MessageType>::TestValidDataForType(
979979
std::string unpacked_proto_expected;
980980

981981
for (size_t i = 0; i < values.size(); i++) {
982-
default_proto_unpacked +=
983-
absl::StrCat(tag(rep_field->number(), wire_type), values[i].first);
984-
default_proto_unpacked_expected +=
985-
absl::StrCat(tag(rep_field->number(), wire_type), values[i].second);
982+
absl::StrAppend(&default_proto_unpacked,
983+
tag(rep_field->number(), wire_type), values[i].first);
984+
absl::StrAppend(&default_proto_unpacked_expected,
985+
tag(rep_field->number(), wire_type), values[i].second);
986986
default_proto_packed += values[i].first;
987987
default_proto_packed_expected += values[i].second;
988-
packed_proto_unpacked +=
989-
absl::StrCat(tag(packed_field->number(), wire_type), values[i].first);
988+
absl::StrAppend(&packed_proto_unpacked,
989+
tag(packed_field->number(), wire_type), values[i].first);
990990
packed_proto_packed += values[i].first;
991991
packed_proto_expected += values[i].second;
992-
unpacked_proto_unpacked += absl::StrCat(
993-
tag(unpacked_field->number(), wire_type), values[i].first);
992+
absl::StrAppend(&unpacked_proto_unpacked,
993+
tag(unpacked_field->number(), wire_type),
994+
values[i].first);
994995
unpacked_proto_packed += values[i].first;
995-
unpacked_proto_expected += absl::StrCat(
996-
tag(unpacked_field->number(), wire_type), values[i].second);
996+
absl::StrAppend(&unpacked_proto_expected,
997+
tag(unpacked_field->number(), wire_type),
998+
values[i].second);
997999
}
9981000
default_proto_packed = absl::StrCat(
9991001
tag(rep_field->number(), WireFormatLite::WIRETYPE_LENGTH_DELIMITED),
@@ -1105,8 +1107,8 @@ void BinaryAndJsonConformanceSuiteImpl<
11051107
const FieldDescriptor* field =
11061108
GetFieldForType(FieldDescriptor::TYPE_MESSAGE, false);
11071109
for (size_t i = 0; i < values.size(); i++) {
1108-
proto += absl::StrCat(
1109-
tag(field->number(), WireFormatLite::WIRETYPE_LENGTH_DELIMITED),
1110+
absl::StrAppend(
1111+
&proto, tag(field->number(), WireFormatLite::WIRETYPE_LENGTH_DELIMITED),
11101112
values[i]);
11111113
}
11121114

0 commit comments

Comments
 (0)