Merge pull request #17806 from anandolee/28.x

zhangskz · web-flow · commit c6964f65567b · 2024-08-13T18:21:49.000-04:00
Raise warnings for deprecated python cpp extension GetDebugString().
diff --git a/python/google/protobuf/pyext/descriptor.cc b/python/google/protobuf/pyext/descriptor.cc
@@ -1508,6 +1508,11 @@ static int SetHasOptions(PyFileDescriptor *self, PyObject *value,
 }
 
 static PyObject* GetDebugString(PyFileDescriptor* self) {
+  PyErr_Warn(nullptr,
+             "GetDebugString() API is deprecated. This API only "
+             "exists in protobuf c++ and does not exists in pure python, upb "
+             "or any other languages. GetDebugString() for python cpp "
+             "extension will be removed in Jan 2025");
   return PyString_FromCppString(_GetDescriptor(self)->DebugString());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1508,6 +1508,11 @@ static int SetHasOptions(PyFileDescriptor self, PyObject value,`
`1508`	`1508`	`}`
`1509`	`1509`
`1510`	`1510`	`static PyObject* GetDebugString(PyFileDescriptor* self) {`
	`1511`	`+ PyErr_Warn(nullptr,`
	`1512`	`+ "GetDebugString() API is deprecated. This API only "`
	`1513`	`+ "exists in protobuf c++ and does not exists in pure python, upb "`
	`1514`	`+ "or any other languages. GetDebugString() for python cpp "`
	`1515`	`+ "extension will be removed in Jan 2025");`
`1511`	`1516`	`return PyString_FromCppString(_GetDescriptor(self)->DebugString());`
`1512`	`1517`	`}`
`1513`	`1518`