Mark mutable repeated fields/maps as [[nodiscard]]

Since these fields have implicit presence, these are no-ops if the returned
pointer is unused.  These are logically constant, but named "mutable_..." and
are non-const methods of the class in order to return the non-const references.
Ignoring the return value likely indicates an omission on the part of the
caller, an error by confusing it with explicit presence fields (like scalar
submessages or strings), or a call that can be cleaned up.

PiperOrigin-RevId: 839401150

Author: ckennelly

src/google/protobuf/compiler/cpp/field_generators/enum_field.cc

@@ -409,7 +409,7 @@ void RepeatedEnum::GenerateAccessorDeclarations(io::Printer* p) const {
     $DEPRECATED$ void $set_name$(int index, $Enum$ value);
     $DEPRECATED$ void $add_name$($Enum$ value);
     [[nodiscard]] $DEPRECATED$ const $pb$::RepeatedField<int>& $name$() const;
-    $DEPRECATED$ $pb$::RepeatedField<int>* $nonnull$ $mutable_name$();
+    [[nodiscard]] $DEPRECATED$ $pb$::RepeatedField<int>* $nonnull$ $mutable_name$();
 
     private:
     const $pb$::RepeatedField<int>& $_internal_name$() const;

src/google/protobuf/compiler/cpp/field_generators/map_field.cc

@@ -206,7 +206,7 @@ void Map::GenerateAccessorDeclarations(io::Printer* p) const {
                                            io::AnnotationCollector::kAlias));
   p->Emit(R"cc(
     [[nodiscard]] $DEPRECATED$ const $Map$& $name$() const;
-    $DEPRECATED$ $Map$* $nonnull$ $mutable_name$();
+    [[nodiscard]] $DEPRECATED$ $Map$* $nonnull$ $mutable_name$();
 
     private:
     const $Map$& $_internal_name$() const;

src/google/protobuf/compiler/cpp/field_generators/message_field.cc

@@ -758,8 +758,9 @@ void RepeatedMessage::GenerateAccessorDeclarations(io::Printer* p) const {
                                            io::AnnotationCollector::kAlias));
 
   p->Emit(R"cc(
-    $DEPRECATED$ $Submsg$* $nonnull$ $mutable_name$(int index);
-    $DEPRECATED$ $pb$::RepeatedPtrField<$Submsg$>* $nonnull$ $mutable_name$();
+    [[nodiscard]] $DEPRECATED$ $Submsg$* $nonnull$ $mutable_name$(int index);
+    [[nodiscard]] $DEPRECATED$ $pb$::RepeatedPtrField<$Submsg$>* $nonnull$
+    $mutable_name$();
 
     private:
     const $pb$::RepeatedPtrField<$Submsg$>& $_internal_name$() const;

src/google/protobuf/compiler/cpp/field_generators/string_field.cc

@@ -848,7 +848,8 @@ void RepeatedString::GenerateAccessorDeclarations(io::Printer* p) const {
     $DEPRECATED$ void $add_name$(Arg_&& value, Args_... args);
     [[nodiscard]] $DEPRECATED$ const $pb$::RepeatedPtrField<::std::string>&
     $name$() const;
-    $DEPRECATED$ $pb$::RepeatedPtrField<::std::string>* $nonnull$ $mutable_name$();
+    [[nodiscard]] $DEPRECATED$ $pb$::RepeatedPtrField<::std::string>* $nonnull$
+    $mutable_name$();
 
     private:
     const $pb$::RepeatedPtrField<::std::string>& _internal_$name$() const;

src/google/protobuf/compiler/cpp/field_generators/string_view_field.cc

@@ -719,7 +719,8 @@ void RepeatedStringView::GenerateAccessorDeclarations(io::Printer* p) const {
     $DEPRECATED$ void add_$name$(Arg_&& value);
     [[nodiscard]] $DEPRECATED$ const $pb$::RepeatedPtrField<::std::string>&
     $name$() const;
-    $DEPRECATED$ $pb$::RepeatedPtrField<::std::string>* $nonnull$ $mutable_name$();
+    [[nodiscard]] $DEPRECATED$ $pb$::RepeatedPtrField<::std::string>* $nonnull$
+    $mutable_name$();
 
     private:
     const $pb$::RepeatedPtrField<::std::string>& _internal_$name$() const;