Skip to content

Commit aca4cfc

Browse files
zhangskzcopybara-github
authored andcommitted
Clean up test case to set features using custom descriptor directly instead of via reparse.
PiperOrigin-RevId: 645116300
1 parent 7122ba1 commit aca4cfc

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

java/core/src/test/java/com/google/protobuf/DescriptorsTest.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -577,10 +577,12 @@ public void testEditionFieldDescriptorLegacyEnumFieldTreatedAsClosedCustomPool()
577577
DescriptorProtos.FieldOptions.newBuilder()
578578
.setFeatures(
579579
DescriptorProtos.FeatureSet.newBuilder()
580-
.setExtension(
581-
// Extension cannot be directly set using custom
582-
// descriptor, so set using generated for now.
583-
JavaFeaturesProto.java_,
580+
.setField(
581+
// Set extension using custom descriptor
582+
javaFeaturesDescriptor.findExtensionByName(
583+
JavaFeaturesProto.java_
584+
.getDescriptor()
585+
.getName()),
584586
JavaFeaturesProto.JavaFeatures.newBuilder()
585587
.setLegacyClosedEnum(true)
586588
.build())
@@ -597,14 +599,6 @@ public void testEditionFieldDescriptorLegacyEnumFieldTreatedAsClosedCustomPool()
597599
.build())
598600
.build())
599601
.build();
600-
// Reparse using custom java features descriptor.
601-
ExtensionRegistry registry = ExtensionRegistry.newInstance();
602-
registry.add(
603-
javaFeaturesDescriptor.getExtensions().get(0),
604-
DynamicMessage.getDefaultInstance(
605-
javaFeaturesDescriptor.getExtensions().get(0).getMessageType()));
606-
editionsClosedEnumFile =
607-
FileDescriptorProto.parseFrom(editionsClosedEnumFile.toByteString(), registry);
608602
Descriptor editionsClosedMessage =
609603
Descriptors.FileDescriptor.buildFrom(
610604
editionsClosedEnumFile,

0 commit comments

Comments
 (0)