Fix PHP 8.4 deprecation in GPBDecodeException (#21232)

TomA-R · copybara-github · commit 676666ef57f3 · 2025-04-18T23:34:12.000-07:00
PHP 8.4 deprecates implicitly nullable parameter declarations. This patch addresses an issue in `Google\Protobuf\Internal\GPBDecodeException` which triggers a deprecation warning. The deprecation warning that's fixed is: ``` vendor/google/protobuf/src/Google/Protobuf/Internal/GPBDecodeException.php:14 Google\Protobuf\Internal\GPBDecodeException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead ``` See also: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated There are no automated tests to be added here since it simply fixes the deprecation warning. Closes #21232 COPYBARA_INTEGRATE_REVIEW=#21232 from TomA-R:php84_nullable_gpbdecodeexception 7cdcb75 PiperOrigin-RevId: 749265866
diff --git a/php/src/Google/Protobuf/Internal/GPBDecodeException.php b/php/src/Google/Protobuf/Internal/GPBDecodeException.php
@@ -14,7 +14,7 @@ class GPBDecodeException extends \Exception
     public function __construct(
         $message,
         $code = 0,
-        \Exception $previous = null)
+        ?\Exception $previous = null)
     {
         parent::__construct(
             "Error occurred during parsing: " . $message,

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class GPBDecodeException extends \Exception`
`14`	`14`	`public function __construct(`
`15`	`15`	`$message,`
`16`	`16`	`$code = 0,`
`17`		`- \Exception $previous = null)`
	`17`	`+ ?\Exception $previous = null)`
`18`	`18`	`{`
`19`	`19`	`parent::__construct(`
`20`	`20`	`"Error occurred during parsing: " . $message,`