Skip to content

Commit 1ca37de

Browse files
authored
protobuf: update php from macos-13 to macos-15-intel (#24776)
* protobuf: update php from macos-13 to macos-15-intel * protobuf: update php from macos-13 to macos-15-intel * update tests from macos-13 to macos-14 * update tests from macos-13 to macos-14
1 parent bc64ed9 commit 1ca37de

File tree

7 files changed

+46
-26
lines changed

7 files changed

+46
-26
lines changed

.github/BUILD.bazel

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,19 @@
11
# This information is extracted from the MacOS runner specs located at:
2-
# https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
2+
# https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md
33
#
44
# When updating, also ensure the "xcode_destination" entries in
55
# `.github/workflows/test_objectivec.yml` are supported for the given versions
66
# of Xcode.
7+
xcode_version(
8+
name = "version16_0",
9+
version = "16.0",
10+
aliases = ["160", "16.0"],
11+
default_ios_sdk_version = "17.2",
12+
default_tvos_sdk_version = "17.2",
13+
default_macos_sdk_version = "15.0",
14+
default_watchos_sdk_version = "10.2",
15+
)
16+
717
xcode_version(
818
name = "version15_2_15C500b",
919
aliases = [
@@ -45,10 +55,17 @@ xcode_version(
4555

4656
xcode_config(
4757
name = "host_xcodes",
48-
default = ":version14_2_14C18",
58+
default = ":version15_2_15C500b",
4959
versions = [
5060
":version15_2_15C500b",
5161
":version14_2_14C18",
5262
":version14_1_0_14B47b",
5363
],
5464
)
65+
66+
# https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md
67+
xcode_config(
68+
name = "host_xcodes_macos15",
69+
versions = [":version16_0"],
70+
default = ":version16_0",
71+
)

.github/workflows/test_cpp.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -356,18 +356,18 @@ jobs:
356356
matrix:
357357
include:
358358
- name: MacOS Bazel
359-
os: macos-13
360-
cache_key: macos-13
359+
os: macos-14
360+
cache_key: macos-14
361361
bazel: test //src/... //third_party/utf8_range/... //conformance:conformance_framework_tests
362362
- name: MacOS Bazel 7
363-
os: macos-13
364-
cache_key: macos-13-bazel7
363+
os: macos-14
364+
cache_key: macos-14-bazel7
365365
bazel: test //src/... //third_party/utf8_range/... //conformance:conformance_framework_tests
366366
bazel_version: '7.1.2'
367367
continuous-only: true
368368
- name: MacOS Apple Silicon (build only) Bazel
369-
os: macos-13
370-
cache_key: macos-13-arm
369+
os: macos-14
370+
cache_key: macos-14-arm
371371
# Current github runners are all Intel based, so just build/compile
372372
# for Apple Silicon to detect issues there.
373373
bazel: build --cpu=darwin_arm64 //src/... //third_party/utf8_range/... //conformance:conformance_framework_tests
@@ -404,7 +404,7 @@ jobs:
404404
matrix:
405405
include:
406406
- name: MacOS CMake
407-
os: macos-13
407+
os: macos-14
408408
flags: -DCMAKE_CXX_STANDARD=14
409409
cache-prefix: macos-cmake
410410
continuous-only: true

.github/workflows/test_objectivec.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,17 @@ jobs:
3636
destination: "platform=macOS"
3737
xc_project: "ProtocolBuffers_OSX.xcodeproj"
3838
- platform: "iOS"
39-
destination: "platform=iOS Simulator,name=iPhone 14,OS=latest"
39+
destination: "platform=iOS Simulator,name=iPhone 15,OS=latest"
4040
xc_project: "ProtocolBuffers_iOS.xcodeproj"
4141
# We run presubmits on all "Debug" entries, but not on "Release" entries
4242
- xc_config: "Debug"
4343
- xc_config: "Release"
4444
continuous-only: true
4545

4646
name: ${{ matrix.continuous-only && inputs.continuous-prefix || '' }} Xcode ${{ matrix.platform}} ${{ matrix.xc_config }}
47-
runs-on: macos-13
47+
runs-on: macos-14
4848
env:
49-
DEVELOPER_DIR: /Applications/Xcode_14.1.app/Contents/Developer
49+
DEVELOPER_DIR: /Applications/Xcode_15.2.app/Contents/Developer
5050
steps:
5151
- name: Checkout pending changes
5252
if: ${{ !matrix.continuous-only || inputs.continuous-run }}
@@ -67,6 +67,7 @@ jobs:
6767
env:
6868
CC: ${{ github.workspace }}/ci/clang_wrapper
6969
CXX: ${{ github.workspace }}/ci/clang_wrapper++
70+
CODE_SIGN_IDENTITY: "-"
7071
with:
7172
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
7273
command: |
@@ -90,8 +91,8 @@ jobs:
9091
PLATFORM: ["ios", "macos", "tvos", "watchos"]
9192
CONFIGURATION: ["Debug", "Release"]
9293
include:
93-
- OS: macos-13
94-
XCODE: "14.1"
94+
- OS: macos-14
95+
XCODE: "15.2"
9596
# We run presubmits on all "Debug" entries, but not on "Release" entries
9697
- CONFIGURATION: "Debug"
9798
- CONFIGURATION: "Release"
@@ -147,7 +148,7 @@ jobs:
147148
- platform: "macOS"
148149
bazel_targets: //objectivec/...
149150
name: ${{ matrix.config.continuous-only && inputs.continuous-prefix || '' }} Bazel ${{ matrix.platform }} ${{ matrix.config.name }}
150-
runs-on: macos-13
151+
runs-on: macos-14
151152
steps:
152153
- name: Checkout pending changes
153154
if: ${{ !matrix.config.continuous-only || inputs.continuous-run }}

.github/workflows/test_php.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ jobs:
185185

186186
name: ${{ matrix.continuous-only && inputs.continuous-prefix || '' }} MacOS PHP ${{ matrix.version }}
187187
# noop
188-
runs-on: macos-13
188+
runs-on: macos-15-intel
189189
steps:
190190
- name: Checkout pending changes
191191
if: ${{ !matrix.continuous-only || inputs.continuous-run }}
@@ -215,6 +215,8 @@ jobs:
215215
uses: protocolbuffers/protobuf-ci/bash@v4
216216
with:
217217
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
218+
# TODO(b/467211650) this shouldn't be necessary, remove it
219+
bazel-flags: --xcode_version_config=//.github:host_xcodes_macos15
218220
command: |
219221
pushd php
220222
php -v
@@ -228,5 +230,5 @@ jobs:
228230
uses: protocolbuffers/protobuf-ci/bazel@v4
229231
with:
230232
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
231-
bazel-cache: php_macos/${{ matrix.version }}
232-
bazel: test //php:conformance_test_c --action_env=PATH --test_env=PATH
233+
bazel-cache: php_macos15/${{ matrix.version }}
234+
bazel: test //php:conformance_test_c --action_env=PATH --test_env=PATH --xcode_version_config=//.github:host_xcodes_macos15

.github/workflows/test_python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
flags: --define=use_fast_cpp_protos=true
8484

8585
name: MacOS ${{ matrix.type }} ${{ matrix.version }}
86-
runs-on: macos-13
86+
runs-on: macos-14
8787
steps:
8888
- name: Checkout pending changes
8989
uses: protocolbuffers/protobuf-ci/checkout@v4

.github/workflows/test_ruby.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ jobs:
142142
- { version: "3.3", ffi: FFI }
143143

144144
name: ${{ matrix.continuous-only && inputs.continuous-prefix || '' }} MacOS Ruby ${{ matrix.version }}${{ matrix.ffi == 'FFI' && ' FFI' || '' }}
145-
runs-on: macos-13
145+
runs-on: macos-14
146146
steps:
147147
- name: Checkout pending changes
148148
if: ${{ !matrix.continuous-only || inputs.continuous-run }}
@@ -152,7 +152,7 @@ jobs:
152152

153153
- name: Pin Ruby version
154154
if: ${{ !matrix.continuous-only || inputs.continuous-run }}
155-
uses: ruby/setup-ruby@961f85197f92e4842e3cb92a4f97bd8e010cdbaf # v1.165.0
155+
uses: ruby/setup-ruby@4a9ddd6f338a97768b8006bf671dfbad383215f4 # v1.207.0
156156
with:
157157
ruby-version: ${{ matrix.version }}
158158

.github/workflows/test_upb.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
- { name: "macOS", bazel-command: "test" }
109109
- { name: "macOS ARM (build only)", bazel-command: "build", flags: "--cpu=darwin_arm64" }
110110
name: ${{ matrix.config.name }}
111-
runs-on: macos-13
111+
runs-on: macos-14
112112
steps:
113113
- name: Checkout pending changes
114114
uses: protocolbuffers/protobuf-ci/checkout@v4
@@ -187,13 +187,13 @@ jobs:
187187
# supported Python versions and assume this gives us sufficient test
188188
# coverage.
189189
- { os: ubuntu-latest, python-version: "3.8", architecture: x64, type: 'binary' }
190-
- { os: macos-13, python-version: "3.8", architecture: x64, type: 'binary' }
190+
- { os: macos-14, python-version: "3.8", architecture: arm64, type: 'binary' }
191191
- { os: ubuntu-latest, python-version: "3.12", architecture: x64, type: 'binary' }
192-
- { os: macos-13, python-version: "3.12", architecture: x64, type: 'binary' }
192+
- { os: macos-14, python-version: "3.12", architecture: arm64, type: 'binary' }
193193
- { os: ubuntu-latest, python-version: "3.8", architecture: x64, type: 'source', continuous-only: true }
194-
- { os: macos-13, python-version: "3.8", architecture: x64, type: 'source', continuous-only: true }
194+
- { os: macos-14, python-version: "3.8", architecture: arm64, type: 'source', continuous-only: true }
195195
- { os: ubuntu-latest, python-version: "3.12", architecture: x64, type: 'source', continuous-only: true }
196-
- { os: macos-13, python-version: "3.12", architecture: x64, type: 'source', continuous-only: true }
196+
- { os: macos-14, python-version: "3.12", architecture: arm64, type: 'source', continuous-only: true }
197197

198198
# Windows uses the full API up until Python 3.10.
199199
- { os: windows-2022, python-version: "3.8", architecture: x86, type: 'binary', continuous-only: true }

0 commit comments

Comments
 (0)