fix: Remove inquire submodule

[dcodeIO]

Removes the obsolete inquire submodule because keeping it around is still causing issues with bundlers. This is technically a small breaking API change, but I think it is safe to assume that the protobuf.util.inquire API is not used given its inherent issues. If it is used, which I doubt, the straightforward fix would be to add @protobufjs/inquire as an explicit dependency.

See #2278 (comment)

[deiga]

You'll be "happy" to hear, that on 7.6.3 we are still seeing the same issue 😬

WARNING in ../../node_modules/@protobufjs/inquire/index.js 16:15-33
  ⚠ Critical dependency: the request of a dependency is an expression
    ╭─[16:22]
 14 │       return null;
 15 │     }
 16 │     var mod = require(moduleName);
    ·                       ──────────
 17 │     if (mod && (mod.length || Object.keys(mod).length)) return mod;
 18 │     return null;
    ╰────

These are all places I could find where @protobufjs/inquire are mentioned:

• node_modules/protobufjs/src/util/minimal.js:util.inquire = require("@protobufjs/inquire");
• node_modules/protobufjs/package.json: "@protobufjs/inquire": "^1.1.2",
• node_modules/protobufjs/dist/light/protobuf.js.map:...
• node_modules/protobufjs/dist/light/protobuf.min.js.map:...
• node_modules/protobufjs/dist/protobuf.js.map:...
• node_modules/protobufjs/dist/minimal/protobuf.js.map:...
• node_modules/protobufjs/dist/minimal/protobuf.min.js.map:...
• node_modules/protobufjs/dist/protobuf.min.js.map:...
• node_modules/@protobufjs/inquire/package.json: "name": "@protobufjs/inquire",
• node_modules/@protobufjs/inquire/README.md:...

[dcodeIO]

That's in so far expected that the inquire submodule has been pulled from main/8.x in v8.6.1, but not from 7.x. Can possibly be backported, but I'm also curious what is blocking an upgrade to 8.x in your case?

[deiga]

That's in so far expected that the inquire submodule has been pulled from main/8.x in v8.6.1, but not from 7.x. Can possibly be backported, but I'm also curious what is blocking an upgrade to 8.x in your case?

It's not a direct dependency in our project, so upgrading means forcing resolution or nudging our deps to upgrade. Neither of which is particularly easy 😬

[dcodeIO]

Now backported to 7.x, with the inquire submodule removed there as well.

[deiga]

Lovely, thanks! 😍

Will test out ASAP!