From d589dbcab3426f837a016be6345707642da79777 Mon Sep 17 00:00:00 2001 From: Kamil Dziedzic Date: Thu, 28 Jun 2018 17:07:59 +0200 Subject: [PATCH] Use native DB.Ping() instead of self-written implementation. Signed-off-by: Kamil Dziedzic --- collector/exporter.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/collector/exporter.go b/collector/exporter.go index 95447697..829a2d87 100644 --- a/collector/exporter.go +++ b/collector/exporter.go @@ -25,8 +25,6 @@ const ( // See: https://github.com/go-sql-driver/mysql#system-variables sessionSettingsParam = `log_slow_filter=%27tmp_table_on_disk,filesort_on_disk%27` timeoutParam = `lock_wait_timeout=%d` - - upQuery = `SELECT 1` ) // Tunable flags. @@ -117,14 +115,12 @@ func (e *Exporter) scrape(ch chan<- prometheus.Metric) { // Set max lifetime for a connection. db.SetConnMaxLifetime(1 * time.Minute) - isUpRows, err := db.Query(upQuery) - if err != nil { + if err := db.Ping(); err != nil { log.Errorln("Error pinging mysqld:", err) e.metrics.MySQLUp.Set(0) e.metrics.Error.Set(1) return } - isUpRows.Close() e.metrics.MySQLUp.Set(1)