From b83546b4da970cf33423df38c8013c56c49608b3 Mon Sep 17 00:00:00 2001 From: Kirankumar Ambati Date: Fri, 20 Jun 2025 13:02:10 +0530 Subject: [PATCH 1/3] Update SelectPanel.tsx --- packages/react/src/SelectPanel/SelectPanel.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/react/src/SelectPanel/SelectPanel.tsx b/packages/react/src/SelectPanel/SelectPanel.tsx index 7e32dcc0022..bcab1af1952 100644 --- a/packages/react/src/SelectPanel/SelectPanel.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.tsx @@ -23,7 +23,6 @@ import {useFeatureFlag} from '../FeatureFlags' import {announce, announceFromElement} from '@primer/live-region-element' import classes from './SelectPanel.module.css' import {clsx} from 'clsx' -import {heightMap} from '../Overlay/Overlay' import {debounce} from '@github/mini-throttle' import {useResponsiveValue} from '../hooks/useResponsiveValue' import type {ButtonProps, LinkButtonProps} from '../Button/types' @@ -721,7 +720,6 @@ function Panel({ } : {}), style: { - '--max-height': overlayProps?.maxHeight ? heightMap[overlayProps.maxHeight] : heightMap['large'], /* override AnchoredOverlay position */ transform: variant === 'modal' ? 'translate(-50%, -50%)' : undefined, // set maxHeight based on calculated availablePanelHeight when keyboard is visible From cdd7bd0011cad7eeffab1370632bfe7b00ace1ea Mon Sep 17 00:00:00 2001 From: Kirankumar Ambati Date: Fri, 20 Jun 2025 13:02:38 +0530 Subject: [PATCH 2/3] Update SelectPanel.module.css --- packages/react/src/SelectPanel/SelectPanel.module.css | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react/src/SelectPanel/SelectPanel.module.css b/packages/react/src/SelectPanel/SelectPanel.module.css index 4449eefad1c..68bff87d161 100644 --- a/packages/react/src/SelectPanel/SelectPanel.module.css +++ b/packages/react/src/SelectPanel/SelectPanel.module.css @@ -93,7 +93,6 @@ .Message { display: flex; height: 100%; - min-height: min(calc(var(--max-height) - 150px), 324px); /* maxHeight of dialog - (header & footer) */ padding: var(--base-size-24); text-align: center; flex-direction: column; From f4387abe49565c1f9357e9890fd4c82e893459d3 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Thu, 3 Jul 2025 10:43:46 -0400 Subject: [PATCH 3/3] Create three-foxes-promise.md --- .changeset/three-foxes-promise.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/three-foxes-promise.md diff --git a/.changeset/three-foxes-promise.md b/.changeset/three-foxes-promise.md new file mode 100644 index 00000000000..011dc90ee44 --- /dev/null +++ b/.changeset/three-foxes-promise.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +fix: remove min height calc logic for SelectPanel