diff --git a/.changeset/three-foxes-promise.md b/.changeset/three-foxes-promise.md new file mode 100644 index 00000000000..011dc90ee44 --- /dev/null +++ b/.changeset/three-foxes-promise.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +fix: remove min height calc logic for SelectPanel diff --git a/packages/react/src/SelectPanel/SelectPanel.module.css b/packages/react/src/SelectPanel/SelectPanel.module.css index 4449eefad1c..68bff87d161 100644 --- a/packages/react/src/SelectPanel/SelectPanel.module.css +++ b/packages/react/src/SelectPanel/SelectPanel.module.css @@ -93,7 +93,6 @@ .Message { display: flex; height: 100%; - min-height: min(calc(var(--max-height) - 150px), 324px); /* maxHeight of dialog - (header & footer) */ padding: var(--base-size-24); text-align: center; flex-direction: column; diff --git a/packages/react/src/SelectPanel/SelectPanel.tsx b/packages/react/src/SelectPanel/SelectPanel.tsx index 7e32dcc0022..bcab1af1952 100644 --- a/packages/react/src/SelectPanel/SelectPanel.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.tsx @@ -23,7 +23,6 @@ import {useFeatureFlag} from '../FeatureFlags' import {announce, announceFromElement} from '@primer/live-region-element' import classes from './SelectPanel.module.css' import {clsx} from 'clsx' -import {heightMap} from '../Overlay/Overlay' import {debounce} from '@github/mini-throttle' import {useResponsiveValue} from '../hooks/useResponsiveValue' import type {ButtonProps, LinkButtonProps} from '../Button/types' @@ -721,7 +720,6 @@ function Panel({ } : {}), style: { - '--max-height': overlayProps?.maxHeight ? heightMap[overlayProps.maxHeight] : heightMap['large'], /* override AnchoredOverlay position */ transform: variant === 'modal' ? 'translate(-50%, -50%)' : undefined, // set maxHeight based on calculated availablePanelHeight when keyboard is visible