From bde0fb06fffd18d553637f0f3534e8357d68c240 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Mon, 6 Mar 2023 17:52:58 -0500 Subject: [PATCH 1/4] makes 'status' prop required --- src/StateLabel/StateLabel.docs.json | 3 ++- src/StateLabel/StateLabel.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/StateLabel/StateLabel.docs.json b/src/StateLabel/StateLabel.docs.json index 31395c0eb25..9a989a9e737 100644 --- a/src/StateLabel/StateLabel.docs.json +++ b/src/StateLabel/StateLabel.docs.json @@ -12,7 +12,8 @@ }, { "name": "status", - "type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'" + "type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'", + "required": true }, { "name": "sx", diff --git a/src/StateLabel/StateLabel.tsx b/src/StateLabel/StateLabel.tsx index 2c04fb489c7..cf063c9e65d 100644 --- a/src/StateLabel/StateLabel.tsx +++ b/src/StateLabel/StateLabel.tsx @@ -82,7 +82,7 @@ const sizeVariants = variant({ type StyledStateLabelBaseProps = { variant?: 'small' | 'normal' - status?: keyof typeof octiconMap + status: keyof typeof octiconMap } & SxProp const StateLabelBase = styled.span` From 0303df2392804ec250237aa81e5d431c37fbc1f6 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Mon, 6 Mar 2023 17:53:24 -0500 Subject: [PATCH 2/4] adds changeset --- .changeset/serious-balloons-teach.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/serious-balloons-teach.md diff --git a/.changeset/serious-balloons-teach.md b/.changeset/serious-balloons-teach.md new file mode 100644 index 00000000000..9560dc1c752 --- /dev/null +++ b/.changeset/serious-balloons-teach.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Makes StateLabel's 'status' prop required From ff8406df378f50d7062d899eb70a8581136267b9 Mon Sep 17 00:00:00 2001 From: mperrotti Date: Mon, 6 Mar 2023 22:56:30 +0000 Subject: [PATCH 3/4] Update generated/components.json --- generated/components.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generated/components.json b/generated/components.json index 09ca4707715..f3e68add24b 100644 --- a/generated/components.json +++ b/generated/components.json @@ -3880,7 +3880,8 @@ }, { "name": "status", - "type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'" + "type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'", + "required": true }, { "name": "sx", From 73406678c6ea3ba0e17f76a5cb7c7ea52f7623cf Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Tue, 14 Mar 2023 13:16:49 -0400 Subject: [PATCH 4/4] rm shouldAcceptCallWithNoProps test --- src/StateLabel/__tests__/StateLabel.types.test.tsx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/StateLabel/__tests__/StateLabel.types.test.tsx b/src/StateLabel/__tests__/StateLabel.types.test.tsx index 6fe880fff19..c10417956ab 100644 --- a/src/StateLabel/__tests__/StateLabel.types.test.tsx +++ b/src/StateLabel/__tests__/StateLabel.types.test.tsx @@ -1,10 +1,6 @@ import React from 'react' import StateLabel from '../StateLabel' -export function shouldAcceptCallWithNoProps() { - return -} - export function shouldNotAcceptSystemProps() { // @ts-expect-error system props should not be accepted return