Skip to content

Commit 4acd0c8

Browse files
authored
Fix bug where page would be unresponsive if no suggestions provided
1 parent f2b35d7 commit 4acd0c8

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/drafts/MarkdownEditor/_MarkdownInput.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ interface MarkdownInputProps extends Omit<TextareaProps, 'onChange'> {
3030
visible: boolean
3131
}
3232

33+
const emptyArray: [] = [] // constant reference to avoid re-running effects
34+
3335
export const MarkdownInput = forwardRef<HTMLTextAreaElement, MarkdownInputProps>(
3436
(
3537
{
@@ -58,13 +60,13 @@ export const MarkdownInput = forwardRef<HTMLTextAreaElement, MarkdownInputProps>
5860
const [event, setEvent] = useState<ShowSuggestionsEvent | null>(null)
5961

6062
const {trigger: emojiTrigger, calculateSuggestions: calculateEmojiSuggestions} = useEmojiSuggestions(
61-
emojiSuggestions ?? [],
63+
emojiSuggestions ?? emptyArray,
6264
)
6365
const {trigger: mentionsTrigger, calculateSuggestions: calculateMentionSuggestions} = useMentionSuggestions(
64-
mentionSuggestions ?? [],
66+
mentionSuggestions ?? emptyArray,
6567
)
6668
const {trigger: referencesTrigger, calculateSuggestions: calculateReferenceSuggestions} = useReferenceSuggestions(
67-
referenceSuggestions ?? [],
69+
referenceSuggestions ?? emptyArray,
6870
)
6971

7072
const triggers = useMemo(

0 commit comments

Comments
 (0)