You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. (#3284)
* Using button as the underlying tag for ActionList.Item content.
* Fix subnav layout.
* Changing ActionList content to button if the top-level is not a button. ActionMenu is busted.
* Fix issue where ActionList.Item content would render as a button inside ActionMenu, breaking keyboard navigation.
* Create purple-crabs-matter.md
* test(vrt): update snapshots
* Fix bug with MenuContext not being exported properly.
* Fix color violation in ActionList.Item.
* Formatting, update snapshots.
* test(vrt): update snapshots
* Fix a11y violation in ActionList story.
* Formatting.
* Fix ts-ignore comment.
* Adjust line-height when button is rendered.
* Revert "test(vrt): update snapshots"
This reverts commit ba6d863.
* Revert "test(vrt): update snapshots"
This reverts commit 31d5358.
* Update snapshots.
* Remove flexGrow from ActionList.Item to remove extra 1px vertical height.
* Set padding to 0 and put flexGrow back to fix padding issue for ActionList buttons.
* Fix ActionList text wrap story.
* Fix underlinenav story by checking ActionList.Item if as prop is a.
* Update snapshots and formatting.
* Update snapshots.
* If ActionList.Item content is rendered as a button, remove tabIndex from li and fix padding.
* Fix various layout edge cases.
* ts-ignore event handlers on ItemWrapper.
* Update snapshots.
* Revert fontWeight config that differed from production docs.
* Pass selectionVariant prop illegally in UnderlineNav story to fix issue with Selection spans showing up.
* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)
* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163)
* test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler
Failing test for #3162
* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler
* add storybook example: Delayed Menu Close
* update docs
* docs: changeset
* Update changelog
---------
Co-authored-by: Siddharth Kshetrapal <[email protected]>
* Update generated/components.json
---------
Co-authored-by: Gregor Martynus <[email protected]>
Co-authored-by: siddharthkp <[email protected]>
* Check for tabIndex value in isTopLevelInteractive.
* Reference styles in updated menuProps.
* Updated snapshots.
* Fix padding setting instead of using values from styles, which are inverted.
* Update snapshots.
---------
Co-authored-by: radglob <[email protected]>
Co-authored-by: Gregor Martynus <[email protected]>
Co-authored-by: siddharthkp <[email protected]>
0 commit comments