Fix ARRAYS_OVERLAP function bug

In some arrays containing arrays that contain null values, arrays_overlap
was not properly comparing values. Switch to array_overlap to set based
implementation.

Resolves: #23730

Author: infvg

presto-main-base/src/main/java/com/facebook/presto/operator/scalar/ArraysOverlapFunction.java

@@ -18,11 +18,19 @@
 import com.facebook.presto.common.type.Type;
 import com.facebook.presto.operator.aggregation.TypedSet;
 import com.facebook.presto.spi.function.Description;
+import com.facebook.presto.spi.function.OperatorDependency;
 import com.facebook.presto.spi.function.ScalarFunction;
 import com.facebook.presto.spi.function.SqlNullable;
 import com.facebook.presto.spi.function.SqlType;
 import com.facebook.presto.spi.function.TypeParameter;
 
+import java.lang.invoke.MethodHandle;
+
+import static com.facebook.presto.common.function.OperatorType.IS_DISTINCT_FROM;
+import static com.facebook.presto.common.type.TypeUtils.readNativeValue;
+import static com.facebook.presto.util.Failures.internalError;
+import static com.google.common.base.Defaults.defaultValue;
+
 @ScalarFunction("arrays_overlap")
 @Description("Returns true if arrays have common elements")
 public final class ArraysOverlapFunction
@@ -36,6 +44,7 @@ private ArraysOverlapFunction() {}
     @SqlNullable
     public static Boolean arraysOverlap(
             @TypeParameter("T") Type elementType,
+            @OperatorDependency(operator = IS_DISTINCT_FROM, argumentTypes = {"T", "T"}) MethodHandle elementIsDistinctFrom,
             @SqlType("array(T)") Block leftArray,
             @SqlType("array(T)") Block rightArray)
     {
@@ -59,8 +68,17 @@ public static Boolean arraysOverlap(
                     hasNull = true;
                     continue;
                 }
-                if (elementType.equalTo(leftArray, i, rightArray, j)) {
-                    return true;
+                try {
+                    boolean firstValueNull = leftArray.isNull(i);
+                    Object firstValue = firstValueNull ? defaultValue(elementType.getJavaType()) : readNativeValue(elementType, leftArray, i);
+                    boolean secondValueNull = rightArray.isNull(j);
+                    Object secondValue = secondValueNull ? defaultValue(elementType.getJavaType()) : readNativeValue(elementType, rightArray, j);
+                    if (!(boolean) elementIsDistinctFrom.invoke(firstValue, firstValueNull, secondValue, secondValueNull)) {
+                        return true;
+                    }
+                }
+                catch (Throwable t) {
+                    throw internalError(t);
                 }
             }
         }

presto-main-base/src/test/java/com/facebook/presto/type/TestArrayOperators.java

@@ -1295,6 +1295,8 @@ public void testArraysOverlap()
         assertFunction("ARRAYS_OVERLAP(ARRAY [NULL, 3], ARRAY [2, 1])", BooleanType.BOOLEAN, null);
         assertFunction("ARRAYS_OVERLAP(ARRAY [3, NULL], ARRAY [2, 1])", BooleanType.BOOLEAN, null);
         assertFunction("ARRAYS_OVERLAP(ARRAY [3, NULL], ARRAY [2, 1, NULL])", BooleanType.BOOLEAN, null);
+        assertFunction("ARRAYS_OVERLAP(ARRAY [ARRAY [1, 2], ARRAY [1, NULL]], ARRAY [ARRAY [1, 2]])", BooleanType.BOOLEAN, true);
+        assertFunction("ARRAYS_OVERLAP(ARRAY [ARRAY [1, NULL], ARRAY [1, 2]], ARRAY [ARRAY [1, 2]])", BooleanType.BOOLEAN, true);
 
         assertFunction("ARRAYS_OVERLAP(ARRAY [CAST(1 AS BIGINT), 2], ARRAY [NULL, CAST(2 AS BIGINT)])", BooleanType.BOOLEAN, true);
         assertFunction("ARRAYS_OVERLAP(ARRAY [CAST(1 AS BIGINT), 2], ARRAY [CAST(2 AS BIGINT), NULL])", BooleanType.BOOLEAN, true);
@@ -1405,8 +1407,8 @@ public void testComparison()
         assertFunction("ARRAY [1, 2, null] != ARRAY [1, 2, null]", BOOLEAN, null);
         assertFunction("ARRAY [1, 2, null] != ARRAY [1, null]", BOOLEAN, true);
         assertFunction("ARRAY [1, 3, null] != ARRAY [1, 2, null]", BOOLEAN, true);
-        assertFunction("ARRAY [ARRAY[1], ARRAY[null], ARRAY[2]] != ARRAY [ARRAY[1], ARRAY[2], ARRAY[3]]", BOOLEAN, true);
-        assertFunction("ARRAY [ARRAY[1], ARRAY[null], ARRAY[3]] != ARRAY [ARRAY[1], ARRAY[2], ARRAY[3]]", BOOLEAN, null);
+        assertFunction("ARRAY [ARRAY [1], ARRAY [null], ARRAY [2]] != ARRAY [ARRAY [1], ARRAY [2], ARRAY [3]]", BOOLEAN, true);
+        assertFunction("ARRAY [ARRAY [1], ARRAY [null], ARRAY [3]] != ARRAY [ARRAY [1], ARRAY [2], ARRAY [3]]", BOOLEAN, null);
 
         assertFunction("ARRAY [10, 20, 30] < ARRAY [10, 20, 40, 50]", BOOLEAN, true);
         assertFunction("ARRAY [10, 20, 30] >= ARRAY [10, 20, 40, 50]", BOOLEAN, false);