Skip to content

Commit 6b646c8

Browse files
committed
Review comments
1 parent 7817ebf commit 6b646c8

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

renderer/src/text_layer/sdf_atlas/renderer.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,7 @@ impl SdfAtlasRenderer {
134134
pass.set_pipeline(&self.pipeline);
135135
// DI: May do this inside this renderer and pass a Matrix to prepare?.
136136
pass.set_bind_group(0, context.view_projection_bind_group, &[]);
137-
// DI: May share index buffers between renderers?
138-
//
139-
// OO: Don't pass the full index buffer here, only what's actually needed (it is growing
140-
// only)
141-
137+
// Optimization: May share index buffers between renderers?
142138
let max_quads = batches
143139
.iter()
144140
.map(|b| b.quad_count)
@@ -156,7 +152,7 @@ impl SdfAtlasRenderer {
156152
{
157153
let text_layer_matrix = context.view_projection_matrix * model_matrix;
158154

159-
// OO: Set bind group only once and update the buffer?
155+
// Optimization: Set bind group only once and update the buffer?
160156
context.queue_view_projection_matrix(&text_layer_matrix);
161157

162158
let pass = &mut context.pass;

0 commit comments

Comments
 (0)