Merge pull request #34204 from bdach/multi-leaderboard-hides

Fix multiplayer spectator leaderboard respecting "show leaderboard" config setting

Author: peppy

osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/MultiSpectatorScreen.cs

@@ -154,7 +154,8 @@ private void load()
             });
             leaderboardFlow.Insert(0, Leaderboard = new DrawableGameplayLeaderboard
             {
-                CollapseDuringGameplay = { Value = false }
+                CollapseDuringGameplay = { Value = false },
+                AlwaysShown = true,
             });
 
             LoadComponentAsync(new GameplayChatDisplay(room)

osu.Game/Screens/Play/HUD/DrawableGameplayLeaderboard.cs

@@ -28,6 +28,8 @@ public partial class DrawableGameplayLeaderboard : CompositeDrawable, ISerialisa
 
         public DrawableGameplayLeaderboardScore? TrackedScore { get; private set; }
 
+        public bool AlwaysShown { get; init; }
+
         [SettingSource(typeof(SkinnableComponentStrings), nameof(SkinnableComponentStrings.CollapseDuringGameplay), nameof(SkinnableComponentStrings.CollapseDuringGameplayDescription))]
         public Bindable<bool> CollapseDuringGameplay { get; } = new BindableBool(true);
 
@@ -109,7 +111,7 @@ private void updateState()
             if (Flow.Alpha < 1)
                 scroll.ScrollToStart(false);
 
-            Flow.FadeTo(player?.Configuration.ShowLeaderboard != false && configVisibility.Value ? 1 : 0, 100, Easing.OutQuint);
+            Flow.FadeTo(player?.Configuration.ShowLeaderboard != false && (configVisibility.Value || AlwaysShown) ? 1 : 0, 100, Easing.OutQuint);
             expanded.Value = !CollapseDuringGameplay.Value || userPlayingState.Value != LocalUserPlayingState.Playing || holdingForHUD.Value;
         }