Fix timing of beatmap break overlay (#35566)

Issue was bisected to [this commit](6f1664f)

This change in the commit outlined is what caused the issue:
```diff
BreakOverlay = new BreakOverlay(working.Beatmap.BeatmapInfo.LetterboxInBreaks, ScoreProcessor)
{
  Clock = DrawableRuleset.FrameStableClock,
  ProcessCustomClock = false,
- Breaks = working.Beatmap.Breaks
+ BreakTracker = breakTracker,
},
```

`BreakTracker` always initializes breaks as `new Period(b.StartTime, b.EndTime - BreakOverlay.BREAK_FADE_DURATION);` leaving room at the end to account for the fade before resuming gameplay.

Because of this, changing the `BreakOverlay` to use a `BreakTracker` instead of the original beatmap breaks caused each break to be  `BREAK_FADE_DURATION` shorter than it was originally - which in this case is 325ms - leading to the discrepancy between the background fadeout and the overlay fadeout.

Since the current behavior is 'correct', aligning the overlay with the rest of the beatmap such as background fadeout, I changed the timing to account for the shorter duration instead of revert the overlay initialization.

Author: GioSDA

osu.Game/Screens/Play/BreakOverlay.cs

@@ -165,7 +165,6 @@ protected override void OnNewBeat(int beatIndex, TimingControlPoint timingPoint,
 
         private void updateDisplay(ValueChangedEvent<Period?> period)
         {
-            FinishTransforms(true);
             Scheduler.CancelDelayedTasks();
 
             if (period.NewValue == null)
@@ -180,20 +179,20 @@ private void updateDisplay(ValueChangedEvent<Period?> period)
 
                 remainingTimeAdjustmentBox
                     .ResizeWidthTo(remaining_time_container_max_size, BREAK_FADE_DURATION, Easing.OutQuint)
-                    .Delay(b.Duration - BREAK_FADE_DURATION)
+                    .Delay(b.Duration)
                     .ResizeWidthTo(0);
 
                 remainingTimeBox.ResizeWidthTo(remainingTimeForCurrentPeriod);
 
-                remainingTimeCounter.CountTo(b.Duration).CountTo(0, b.Duration);
+                remainingTimeCounter.CountTo(b.Duration + BREAK_FADE_DURATION).CountTo(0, b.Duration + BREAK_FADE_DURATION);
 
                 remainingTimeCounter.MoveToX(-50)
                                     .MoveToX(0, BREAK_FADE_DURATION, Easing.OutQuint);
 
                 info.MoveToX(50)
                     .MoveToX(0, BREAK_FADE_DURATION, Easing.OutQuint);
 
-                using (BeginDelayedSequence(b.Duration - BREAK_FADE_DURATION))
+                using (BeginDelayedSequence(b.Duration))
                 {
                     fadeContainer.FadeOut(BREAK_FADE_DURATION);
                     breakArrows.Hide(BREAK_FADE_DURATION);

osu.Game/Screens/Play/LetterboxOverlay.cs

@@ -61,8 +61,6 @@ protected override void LoadComplete()
 
         private void updateDisplay(ValueChangedEvent<Period?> period)
         {
-            FinishTransforms(true);
-
             if (period.NewValue == null)
                 return;
 
@@ -71,7 +69,7 @@ private void updateDisplay(ValueChangedEvent<Period?> period)
             using (BeginAbsoluteSequence(b.Start))
             {
                 fadeContainer.FadeInFromZero(BreakOverlay.BREAK_FADE_DURATION);
-                using (BeginDelayedSequence(b.Duration - BreakOverlay.BREAK_FADE_DURATION))
+                using (BeginDelayedSequence(b.Duration))
                     fadeContainer.FadeOut(BreakOverlay.BREAK_FADE_DURATION);
             }
         }