Skip to content

Commit 50b2b54

Browse files
ahunter6bjorn-helgaas
authored andcommitted
PCI/PM: Don't sleep at all when d3_delay or d3cold_delay is zero
msleep() still sleeps 1 jiffy even when told to sleep for zero milliseconds. That can end up being 1-2 milliseconds or more. In the cases of d3_delay and d3cold_delay, that unnecessarily increases suspend and/or resume latencies. Do not sleep at all for the respective cases if d3_delay is zero or d3cold_delay is zero. Signed-off-by: Adrian Hunter <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]>
1 parent c1ae3cf commit 50b2b54

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/pci/pci.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ static void pci_dev_d3_sleep(struct pci_dev *dev)
6666
if (delay < pci_pm_d3_delay)
6767
delay = pci_pm_d3_delay;
6868

69-
msleep(delay);
69+
if (delay)
70+
msleep(delay);
7071
}
7172

7273
#ifdef CONFIG_PCI_DOMAINS
@@ -827,7 +828,8 @@ static void __pci_start_power_transition(struct pci_dev *dev, pci_power_t state)
827828
* because have already delayed for the bridge.
828829
*/
829830
if (dev->runtime_d3cold) {
830-
msleep(dev->d3cold_delay);
831+
if (dev->d3cold_delay)
832+
msleep(dev->d3cold_delay);
831833
/*
832834
* When powering on a bridge from D3cold, the
833835
* whole hierarchy may be powered on into

0 commit comments

Comments
 (0)