Improve some API names

Author: simolus3

packages/powersync_core/lib/src/sync/connection_manager.dart

@@ -380,7 +380,7 @@ final class _SyncStreamSubscriptionHandle implements SyncStreamSubscription {
   @override
   Future<void> waitForFirstSync() async {
     return _source.connections.firstStatusMatching((status) {
-      final currentProgress = status.statusFor(this);
+      final currentProgress = status.forStream(this);
       return currentProgress?.subscription.hasSynced ?? false;
     });
   }

packages/powersync_core/lib/src/sync/sync_status.dart

@@ -117,11 +117,11 @@ final class SyncStatus {
     );
   }
 
-  /// All sync streams currently being tracked in this subscription.
+  /// All sync streams currently being tracked in the database.
   ///
   /// This returns null when the database is currently being opened and we
   /// don't have reliable information about all included streams yet.
-  Iterable<SyncStreamStatus>? get subscriptions {
+  Iterable<SyncStreamStatus>? get syncStreams {
     return _internalSubscriptions?.map((subscription) {
       return SyncStreamStatus._(subscription, downloadProgress);
     });
@@ -166,9 +166,9 @@ final class SyncStatus {
     );
   }
 
-  /// If the [stream] appears in [activeSubscriptions], returns the current
-  /// status for that stream.
-  SyncStreamStatus? statusFor(SyncStreamDescription stream) {
+  /// If the [stream] appears in [syncStreams], returns the current status for
+  /// that stream.
+  SyncStreamStatus? forStream(SyncStreamDescription stream) {
     final raw = _internalSubscriptions?.firstWhereOrNull(
       (e) =>
           e.name == stream.name &&

packages/powersync_core/test/sync/stream_test.dart

@@ -142,18 +142,18 @@ void main() {
 
     var status = await statusStream.next;
     for (final subscription in [a, b]) {
-      expect(status.statusFor(subscription)!.subscription.active, true);
-      expect(status.statusFor(subscription)!.subscription.lastSyncedAt, isNull);
+      expect(status.forStream(subscription)!.subscription.active, true);
+      expect(status.forStream(subscription)!.subscription.lastSyncedAt, isNull);
       expect(
-        status.statusFor(subscription)!.subscription.hasExplicitSubscription,
+        status.forStream(subscription)!.subscription.hasExplicitSubscription,
         true,
       );
     }
 
     syncService.addLine(checkpointComplete(priority: 1));
     status = await statusStream.next;
-    expect(status.statusFor(a)!.subscription.lastSyncedAt, isNull);
-    expect(status.statusFor(b)!.subscription.lastSyncedAt, isNotNull);
+    expect(status.forStream(a)!.subscription.lastSyncedAt, isNull);
+    expect(status.forStream(b)!.subscription.lastSyncedAt, isNotNull);
     await b.waitForFirstSync();
 
     syncService.addLine(checkpointComplete());
@@ -170,7 +170,7 @@ void main() {
       status,
       emits(
         isSyncStatus(
-          subscriptions: [
+          syncStreams: [
             isStreamStatus(
               subscription: isSyncSubscription(
                 name: 'default_stream',
@@ -217,6 +217,6 @@ void main() {
 
     final subscription = await database.syncStream('foo').subscribe();
     var status = await stream.next;
-    expect(status.statusFor(subscription), isNotNull);
+    expect(status.forStream(subscription), isNotNull);
   });
 }

packages/powersync_core/test/sync/utils.dart

@@ -8,7 +8,7 @@ TypeMatcher<SyncStatus> isSyncStatus({
   Object? connecting,
   Object? hasSynced,
   Object? downloadProgress,
-  Object? subscriptions,
+  Object? syncStreams,
 }) {
   var matcher = isA<SyncStatus>();
   if (downloading != null) {
@@ -27,9 +27,8 @@ TypeMatcher<SyncStatus> isSyncStatus({
     matcher = matcher.having(
         (e) => e.downloadProgress, 'downloadProgress', downloadProgress);
   }
-  if (subscriptions != null) {
-    matcher =
-        matcher.having((e) => e.subscriptions, 'subscriptions', subscriptions);
+  if (syncStreams != null) {
+    matcher = matcher.having((e) => e.syncStreams, 'syncStreams', syncStreams);
   }
 
   return matcher;