Skip to content

Commit cf16c03

Browse files
committed
Fix tests
1 parent e021a7e commit cf16c03

File tree

10 files changed

+23
-22
lines changed

10 files changed

+23
-22
lines changed

demos/django-todolist/lib/widgets/guard_by_sync.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import 'package:powersync_django_todolist_demo/powersync.dart';
77
class GuardBySync extends StatelessWidget {
88
final Widget child;
99

10-
/// When set, wait only for a complete sync within the [BucketPriority]
10+
/// When set, wait only for a complete sync within the [StreamPriority]
1111
/// instead of a full sync.
12-
final BucketPriority? priority;
12+
final StreamPriority? priority;
1313

1414
const GuardBySync({
1515
super.key,

demos/supabase-todolist-drift/lib/powersync/powersync.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,19 @@ Future<PowerSyncDatabase> powerSyncInstance(Ref ref) async {
4747
return db;
4848
}
4949

50-
final _syncStatusInternal = StreamProvider((ref) {
50+
final _syncStatusInternal = StreamProvider<SyncStatus?>((ref) {
5151
return Stream.fromFuture(
5252
ref.watch(powerSyncInstanceProvider.future),
53-
).asyncExpand((db) => db.statusStream).startWith(const SyncStatus());
53+
).asyncExpand<SyncStatus?>((db) => db.statusStream).startWith(null);
5454
});
5555

5656
final syncStatus = Provider((ref) {
57+
// ignore: invalid_use_of_internal_member
5758
return ref.watch(_syncStatusInternal).value ?? const SyncStatus();
5859
});
5960

6061
@riverpod
61-
bool didCompleteSync(Ref ref, [BucketPriority? priority]) {
62+
bool didCompleteSync(Ref ref, [StreamPriority? priority]) {
6263
final status = ref.watch(syncStatus);
6364
if (priority != null) {
6465
return status.statusForPriority(priority).hasSynced ?? false;

demos/supabase-todolist-drift/lib/screens/lists.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ final class _ListsWidget extends ConsumerWidget {
3535
@override
3636
Widget build(BuildContext context, WidgetRef ref) {
3737
final lists = ref.watch(listsNotifierProvider);
38-
final didSync = ref.watch(didCompleteSyncProvider(BucketPriority(1)));
38+
final didSync = ref.watch(didCompleteSyncProvider(StreamPriority(1)));
3939

4040
if (!didSync) {
4141
return const Text('Busy with sync...');

demos/supabase-todolist/lib/widgets/guard_by_sync.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import 'package:powersync_flutter_demo/powersync.dart';
77
class GuardBySync extends StatelessWidget {
88
final Widget child;
99

10-
/// When set, wait only for a complete sync within the [BucketPriority]
10+
/// When set, wait only for a complete sync within the [StreamPriority]
1111
/// instead of a full sync.
12-
final BucketPriority? priority;
12+
final StreamPriority? priority;
1313

1414
const GuardBySync({
1515
super.key,

demos/supabase-todolist/lib/widgets/lists_page.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,5 @@ class ListsWidget extends StatelessWidget {
6666
);
6767
}
6868

69-
static final _listsPriority = BucketPriority(1);
69+
static final _listsPriority = StreamPriority(1);
7070
}

packages/powersync_core/lib/src/sync/instruction.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ final class CoreSyncStatus {
9494

9595
static SyncPriorityStatus _priorityStatusFromJson(Map<String, Object?> json) {
9696
return (
97-
priority: BucketPriority(json['priority'] as int),
97+
priority: StreamPriority(json['priority'] as int),
9898
hasSynced: json['has_synced'] as bool?,
9999
lastSyncedAt: switch (json['last_synced_at']) {
100100
null => null,
@@ -123,7 +123,7 @@ final class DownloadProgress {
123123

124124
static BucketProgress _bucketProgressFromJson(Map<String, Object?> json) {
125125
return (
126-
priority: BucketPriority(json['priority'] as int),
126+
priority: StreamPriority(json['priority'] as int),
127127
atLast: json['at_last'] as int,
128128
sinceLast: json['since_last'] as int,
129129
targetCount: json['target_count'] as int,

packages/powersync_core/lib/src/sync/streaming_sync.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ class StreamingSyncImplementation implements StreamingSync {
385385
// checkpoint later.
386386
} else {
387387
_updateStatusForPriority((
388-
priority: BucketPriority(bucketPriority),
388+
priority: StreamPriority(bucketPriority),
389389
lastSyncedAt: DateTime.now(),
390390
hasSynced: true,
391391
));

packages/powersync_core/lib/src/web/sync_worker_protocol.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ extension type SerializedBucketProgress._(JSObject _) implements JSObject {
226226
return {
227227
for (final entry in array.toDart)
228228
entry.name: (
229-
priority: BucketPriority(entry.priority),
229+
priority: StreamPriority(entry.priority),
230230
atLast: entry.atLast,
231231
sinceLast: entry.sinceLast,
232232
targetCount: entry.targetCount,

packages/powersync_core/test/sync/in_memory_sync_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ void _declareTests(String name, SyncOptions options, bool bson) {
618618
Future<void> expectProgress(
619619
StreamQueue<SyncStatus> status, {
620620
required Object total,
621-
Map<BucketPriority, Object> priorities = const {},
621+
Map<StreamPriority, Object> priorities = const {},
622622
}) async {
623623
await expectLater(
624624
status,
@@ -939,11 +939,11 @@ void _declareTests(String name, SyncOptions options, bool bson) {
939939
await Completer<void>().future;
940940
}));
941941

942-
syncClient.streamingSync();
942+
await connect();
943943
await requestStarted.future;
944944
expect(database.currentStatus, isSyncStatus(connecting: true));
945945

946-
await syncClient.abort();
946+
await database.disconnect();
947947
expect(database.currentStatus.anyError, isNull);
948948
});
949949

@@ -962,7 +962,7 @@ void _declareTests(String name, SyncOptions options, bool bson) {
962962
});
963963
await expectLater(status, emits(isSyncStatus(downloading: true)));
964964

965-
await syncClient.abort();
965+
await database.disconnect();
966966
expect(database.currentStatus.anyError, isNull);
967967
});
968968
});

packages/powersync_core/test/sync/sync_types_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -216,11 +216,11 @@ void main() {
216216
}
217217
});
218218

219-
test('bucket priority comparisons', () {
220-
expect(BucketPriority(0) < BucketPriority(3), isFalse);
221-
expect(BucketPriority(0) > BucketPriority(3), isTrue);
222-
expect(BucketPriority(0) >= BucketPriority(3), isTrue);
223-
expect(BucketPriority(0) >= BucketPriority(0), isTrue);
219+
test('stream priority comparisons', () {
220+
expect(StreamPriority(0) < StreamPriority(3), isFalse);
221+
expect(StreamPriority(0) > StreamPriority(3), isTrue);
222+
expect(StreamPriority(0) >= StreamPriority(3), isTrue);
223+
expect(StreamPriority(0) >= StreamPriority(0), isTrue);
224224
});
225225
});
226226
}

0 commit comments

Comments
 (0)