Skip to content

Commit 8a017f8

Browse files
dev packages are desynced
1 parent ec9ce6f commit 8a017f8

File tree

7 files changed

+6
-4
lines changed

7 files changed

+6
-4
lines changed

libs/lib-services/src/system/LifeCycledSystem.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import { ServiceError } from '@powersync/service-errors';
1010
import { container } from '../container.js';
1111
import { logger } from '../logger/Logger.js';
12-
12+
// TODO: REMOVE THIS COMMENT
1313
export type LifecycleCallback<T> = (singleton: T) => Promise<void> | void;
1414

1515
export type PartialLifecycle<T> = {

modules/module-mongodb-storage/src/storage/MongoReportStorage.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { event_types } from '@powersync/service-types';
44
import { PowerSyncMongo } from './implementation/db.js';
55
import { SdkConnectDocument } from './implementation/models.js';
66

7+
// import { SdkConnectDocument } from './implementation/models.js';
78
export class MongoReportStorage implements storage.ReportStorageFactory {
89
private readonly client: mongo.MongoClient;
910
public readonly db: PowerSyncMongo;

modules/module-mongodb-storage/src/storage/implementation/MongoStorageProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class MongoStorageProvider implements storage.BucketStorageProvider {
4343
slot_name_prefix: resolvedConfig.slot_name_prefix
4444
});
4545

46-
// TODO: CREATE REPORT STORAGE FACTORY
46+
// Storage factory for reports
4747
const reportStorageFactory = new MongoReportStorage(database);
4848
return {
4949
storage: syncStorageFactory,

modules/module-postgres-storage/src/storage/PostgresStorageProvider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export class PostgresStorageProvider implements storage.BucketStorageProvider {
2929
slot_name_prefix: options.resolvedConfig.slot_name_prefix
3030
});
3131
return {
32+
// TODO: IMPLEMENT REPORT STORAGE
3233
reportStorage: null,
3334
storage: storageFactory,
3435
shutDown: async () => storageFactory.db[Symbol.asyncDispose](),

packages/service-core/src/storage/ReportStorageFactory.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { PaginatedInstanceRequest, SdkConnectDocument } from '@powersync/service-types/dist/events.js';
22

3+
// Interface for the ReportStorageFactory
34
export interface ReportStorageFactory extends AsyncDisposable {
45
reportSdkConnect(data: SdkConnectDocument): Promise<void>;
56
reportSdkDisconnect(data: SdkConnectDocument): Promise<void>;

packages/service-core/src/storage/StorageProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { ReportStorageFactory } from './ReportStorageFactory.js';
55

66
export interface ActiveStorage {
77
storage: BucketStorageFactory;
8-
// TODO: REMOVE THE NULL ONCE POSTGRES HAS BEEN IMPLEMENTED
8+
// TODO: REMOVE THE NULL ONCE POSTGRES HAS BEEN IMPLEMENTED THIS IS JUST SO I CAN TEST MONGO
99
reportStorage: ReportStorageFactory | null;
1010
shutDown(): Promise<void>;
1111

packages/types/src/events.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export type SdkDisconnectEventData = {
2626
disconnect_at: Date;
2727
} & SdkUserData;
2828

29-
// Mongodb document type for SDK connect and disconnect events
3029
export type SdkConnectDocument = {
3130
_id: bson.ObjectId;
3231
sdk: string;

0 commit comments

Comments
 (0)