Skip to content

Transpile .js files as well if allowJs:true exists in tsconfig.json #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Transpile .js files as well if allowJs:true exists in tsconfig.json #28

wants to merge 1 commit into from

Conversation

twada
Copy link
Member

@twada twada commented May 25, 2017 •
edited
Loading

This PR adds .js files to transpile target as well if and only if allowJs:true exists in tsconfig.json

@teppeis, I have two questions.

  1. Is this PR matches to espower-typescript's philosophy? (If not, please feel free to reject this PR)
  2. TypeError: Cannot read property 'text' of undefined has occurred. Is this error related to typescript-simple?

@twada
Copy link
Member Author

twada commented May 30, 2017 •
edited
Loading

memo:

to support allowJs:true we should also simulate these options in tsconfig.json:

  • files
  • include
  • exclude

It's a bit hard way since globbing logic isn't exposed.

@teppeis
Copy link
Contributor

teppeis commented May 30, 2017

It's a bit hard way since globbing logic isn't exposed.

TypeScript has no public API for the purpose, so we need to implement it by ourself...

@teppeis teppeis mentioned this pull request Jun 24, 2018
Merged
@teppeis teppeis closed this Jun 24, 2018
@teppeis teppeis deleted the allow-js branch June 24, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twada @teppeis