-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
I'd like to deprecate the create_chat_func
in favor of a client
argument which could be a function, as in create_chat_func
, but could also be an ellmer::Chat
object.
This is feasible because we only need to set the system prompt
Line 226 in e2ced68
chat <- create_chat_func(system_prompt = system_prompt) |
which is possible using the $set_system_prompt()
method.
This does introduce a few new issues:
- If
client
is aChat
object, we'll call$clone()
to create a new chat. - Should we remove turns from the
client
?- I think yes: it maintains current behavior.)
- Should we remove additional tools from the
client
?- I think maybe not, that could be an interesting way to extend querychat.
Metadata
Metadata
Assignees
Labels
No labels