Skip to content

Commit 975d762

Browse files
committed
quietly switch submodule url for all libs fetched from gopkg.in.
gopkg.in is... a cute idea. If you don't have any other version control. If you *DO* have version control -- say, a nice thing like git submodules -- then that site just gets in your way *massively*. In a particular strike of irony, what brings this to my attention is that I want a bugfix in go-git which is several months old: src-d/go-git#623 The joke is... this bug regards go-git's handing of *gopkg.in*. And I can't fetch it because of... gopkg.in. (Even going into our submodule and directly fetching and explicitly asking for `git checkout origin/master` *doesn't work* because gopkg.in works by *lying* about what git master *is*. Whee.) Ke ke ke. So. We can't *not* have the gopkg.in paths in our gopath, because go-git internally references their own packages with that path (I've commented before that I think this is a mistake in another issue: src-d/go-git#76 ... but whatever, moving on); go imports just don't work like that. But we *can* tell git submodules to fetch from somewhere else. And this will actually work fine. Chalk up another point scored for git submodules -- complex? sure; but dang if they don't get the job done, even in an *incredible* variety of complex situations. I'm splitting the actual library updates into a separate commit (it'll be noisy -- guess why. They changed the version of some of their other libraries, so we actually get to see *new paths* from gopkg.in. Fun!). Signed-off-by: Eric Myhre <[email protected]>
1 parent 7fedce9 commit 975d762

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.gitmodules

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
url = https://github.com/syndtr/gocapability
1919
[submodule ".gopath/src/gopkg.in/alecthomas/kingpin.v2"]
2020
path = .gopath/src/gopkg.in/alecthomas/kingpin.v2
21-
url = https://gopkg.in/alecthomas/kingpin.v2
21+
url = https://github.com/alecthomas/kingpin
2222
[submodule ".gopath/src/github.com/alecthomas/template"]
2323
path = .gopath/src/github.com/alecthomas/template
2424
url = https://github.com/alecthomas/template
@@ -33,13 +33,13 @@
3333
url = https://github.com/polydawn/go-timeless-api
3434
[submodule ".gopath/src/gopkg.in/warnings.v0"]
3535
path = .gopath/src/gopkg.in/warnings.v0
36-
url = https://gopkg.in/warnings.v0
36+
url = https://github.com/go-warnings/warnings
3737
[submodule ".gopath/src/gopkg.in/src-d/go-billy.v3"]
3838
path = .gopath/src/gopkg.in/src-d/go-billy.v3
39-
url = https://gopkg.in/src-d/go-billy.v3
39+
url = https://github.com/src-d/go-billy
4040
[submodule ".gopath/src/gopkg.in/src-d/go-git.v4"]
4141
path = .gopath/src/gopkg.in/src-d/go-git.v4
42-
url = https://gopkg.in/src-d/go-git.v4
42+
url = https://github.com/src-d/go-git
4343
[submodule ".gopath/src/golang.org/x/crypto"]
4444
path = .gopath/src/golang.org/x/crypto
4545
url = https://go.googlesource.com/crypto

0 commit comments

Comments
 (0)