User-passed props should overwrite those returned by fetchCSB #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current ordering of props destructuring prevents applying custom screenshot_url to CSBs. This quick PR fixes that.
jo-chemla
added a commit
to jo-chemla/react-three-fiber
that referenced
this pull request
Feb 21, 2025
See fix here pmndrs/docs#375 Fixed the fact that the ordering of props destructuring prevented applying custom screenshot_url to CSBs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ordering of props destructuring prevents applying custom screenshot_url to CSBs. This quick PR fixes that.