Collect children props in component registry, serve in config.

Author: T4rk1n

dash/dash-renderer/src/TreeContainer.js

@@ -20,6 +20,7 @@ import {
     pipe,
     propOr,
     path as rpath,
+    pathOr,
     type
 } from 'ramda';
 import {notifyObservers, updateProps} from './actions';
@@ -210,7 +211,15 @@ class BaseTreeContainer extends Component {
         const element = Registry.resolve(_dashprivate_layout);
 
         // Hydrate components props
-        const childrenProps = propOr([], 'childrenProps', _dashprivate_layout);
+        const childrenProps = pathOr(
+            [],
+            [
+                'children_props',
+                _dashprivate_layout.namespace,
+                _dashprivate_layout.type
+            ],
+            _dashprivate_config
+        );
         const props = pipe(
             dissoc('children'),
             ...childrenProps

dash/dash.py

@@ -615,6 +615,7 @@ def _config(self):
             "show_undo_redo": self.config.show_undo_redo,
             "suppress_callback_exceptions": self.config.suppress_callback_exceptions,
             "update_title": self.config.update_title,
+            "children_props": ComponentRegistry.children_props,
         }
         if self._dev_tools.hot_reload:
             config["hot_reload"] = {

dash/development/_py_components_generation.py

@@ -51,11 +51,11 @@ def generate_class_string(
     c = '''class {typename}(Component):
     """{docstring}"""
     _children_props = {children_props}
+    _namespace = '{namespace}'
+    _type = '{typename}'
     @_explicitize_args
     def __init__(self, {default_argtext}):
         self._prop_names = {list_of_valid_keys}
-        self._type = '{typename}'
-        self._namespace = '{namespace}'
         self._valid_wildcard_attributes =\
             {list_of_valid_wildcard_attr_prefixes}
         self.available_properties = {list_of_valid_keys}

dash/development/base_component.py

@@ -1,4 +1,5 @@
 import abc
+import collections
 import inspect
 import sys
 import uuid
@@ -16,6 +17,7 @@ class ComponentRegistry:
     """Holds a registry of the namespaces used by components."""
 
     registry = set()
+    children_props = collections.defaultdict(dict)
 
     @classmethod
     def get_resources(cls, resource_name):
@@ -41,6 +43,9 @@ def __new__(mcs, name, bases, attributes):
             return component
 
         ComponentRegistry.registry.add(module)
+        ComponentRegistry.children_props[attributes.get("_namespace", module)][
+            name
+        ] = attributes.get("_children_props")
 
         return component
 
@@ -222,9 +227,6 @@ def to_plotly_json(self):
             "namespace": self._namespace,  # pylint: disable=no-member
         }
 
-        if self._children_props:
-            as_json["childrenProps"] = self._children_props
-
         return as_json
 
     # pylint: disable=too-many-branches, too-many-return-statements

tests/unit/development/metadata_test.py

@@ -87,11 +87,11 @@ class Table(Component):
 
 - optionalUnion (string | number; optional)"""
     _children_props = ['optionalNode', 'optionalElement']
+    _namespace = 'TableComponents'
+    _type = 'Table'
     @_explicitize_args
     def __init__(self, children=None, optionalArray=Component.UNDEFINED, optionalBool=Component.UNDEFINED, optionalFunc=Component.UNDEFINED, optionalNumber=Component.UNDEFINED, optionalObject=Component.UNDEFINED, optionalString=Component.UNDEFINED, optionalSymbol=Component.UNDEFINED, optionalNode=Component.UNDEFINED, optionalElement=Component.UNDEFINED, optionalMessage=Component.UNDEFINED, optionalEnum=Component.UNDEFINED, optionalUnion=Component.UNDEFINED, optionalArrayOf=Component.UNDEFINED, optionalObjectOf=Component.UNDEFINED, optionalObjectWithExactAndNestedDescription=Component.UNDEFINED, optionalObjectWithShapeAndNestedDescription=Component.UNDEFINED, optionalAny=Component.UNDEFINED, customProp=Component.UNDEFINED, customArrayProp=Component.UNDEFINED, id=Component.UNDEFINED, **kwargs):
         self._prop_names = ['children', 'id', 'aria-*', 'customArrayProp', 'customProp', 'data-*', 'in', 'optionalAny', 'optionalArray', 'optionalArrayOf', 'optionalBool', 'optionalElement', 'optionalEnum', 'optionalNode', 'optionalNumber', 'optionalObject', 'optionalObjectOf', 'optionalObjectWithExactAndNestedDescription', 'optionalObjectWithShapeAndNestedDescription', 'optionalString', 'optionalUnion']
-        self._type = 'Table'
-        self._namespace = 'TableComponents'
         self._valid_wildcard_attributes =            ['data-', 'aria-']
         self.available_properties = ['children', 'id', 'aria-*', 'customArrayProp', 'customProp', 'data-*', 'in', 'optionalAny', 'optionalArray', 'optionalArrayOf', 'optionalBool', 'optionalElement', 'optionalEnum', 'optionalNode', 'optionalNumber', 'optionalObject', 'optionalObjectOf', 'optionalObjectWithExactAndNestedDescription', 'optionalObjectWithShapeAndNestedDescription', 'optionalString', 'optionalUnion']
         self.available_wildcard_properties =            ['data-', 'aria-']