Skip to content

Commit 55b7674

Browse files
authored
Merge pull request #2461 from plotly/fix-2460
Fix pytest make report
2 parents 43cbf3b + 341000b commit 55b7674

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](https://semver.org/).
44

5+
## [UNRELEASED]
6+
7+
## Fixed
8+
9+
- [#2461](https://github.com/plotly/dash/pull/2461) Fix pytest plugin make report when testing not installed, fix [#2420](https://github.com/plotly/dash/issues/2420)
10+
511
## [2.9.0] - 2023-03-16
612

713
## Breaking

dash/testing/plugin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ def pytest_addhooks(pluginmanager):
105105

106106
@pytest.hookimpl(tryfirst=True, hookwrapper=True)
107107
def pytest_runtest_makereport(item, call): # pylint: disable=unused-argument
108-
if not _installed:
109-
return
110108
# execute all other hooks to obtain the report object
111109
outcome = yield
110+
if not _installed:
111+
return
112112
rep = outcome.get_result()
113113

114114
# we only look at actual failing test calls, not setup/teardown

0 commit comments

Comments
 (0)