harmonized the variable for number of pins to no_of_pins across all architectures

Author: pljakobs

Sming/Arch/Esp8266/Core/HardwarePWM.cpp

@@ -54,14 +54,15 @@ static const uint8_t gpioPinFunc[]{
 
 HardwarePWM::HardwarePWM(const uint8_t* pins, uint8_t no_of_pins, bool usePhaseShift ) : channel_count(no_of_pins)
 {
-	if(noOfPins == 0) {
+	_usePhaseShift = usePhaseShift; // Not used on the ESP8266 right now, esp32 hardware can phase shift pwm signals, pretty sure 8266 can't
+	if(no_of_pins == 0) {
 		return;
 	}
 
 	uint32_t ioInfo[PWM_CHANNEL_NUM_MAX][3];   // pin information
 	uint32_t pwmDutyInit[PWM_CHANNEL_NUM_MAX]; // pwm duty
 	unsigned pinCount = 0;
-	for(uint8_t i = 0; i < noOfPins; i++) {
+	for(uint8_t i = 0; i < no_of_pins; i++) {
 		auto pin = pins[i];
 		assert(pin < 16);
 		if(pin >= 16) {

Sming/Arch/Rp2040/Core/HardwarePWM.cpp

@@ -33,12 +33,13 @@
 
 HardwarePWM::HardwarePWM(const uint8_t* pins, uint8_t no_of_pins, bool usePhaseShift ) : channel_count(no_of_pins)
 {
-	assert(noOfPins > 0 && noOfPins <= PWM_CHANNEL_NUM_MAX);
-	noOfPins = std::min(uint8_t(PWM_CHANNEL_NUM_MAX), noOfPins);
-	std::copy_n(pins, noOfPins, channels);
+	_usePhaseShift = usePhaseShift; // Not used on the RP2040 right now, esp32 hardware can phase shift pwm signals, not sure if that's available in RP2040
+	assert(no_of_pins > 0 && no_of_pins <= PWM_CHANNEL_NUM_MAX);
+	no_of_pins = std::min(uint8_t(PWM_CHANNEL_NUM_MAX), no_of_pins);
+	std::copy_n(pins, no_of_pins, channels);
 	setPeriod(1e6 / PWM_FREQ_DEFAULT);
 
-	for(unsigned i = 0; i < noOfPins; ++i) {
+	for(unsigned i = 0; i < no_of_pins; ++i) {
 		auto pin = channels[i];
 		gpio_set_function(pin, GPIO_FUNC_PWM);
 		gpio_set_dir(pin, GPIO_OUT);