Fix esp32 tcpip message starvation (SmingHub#2976)

mikee47 · web-flow · commit 3da1acd40fed · 2025-09-17T12:59:35.000+02:00
Limit sming task processing to only those messages waiting in the queue. When heavily stressed, loop never exits and tcpip messages don't get serviced. See SmingHub#2971 (comment)
diff --git a/Sming/Arch/Esp32/Components/esp32/src/tasks.cpp b/Sming/Arch/Esp32/Components/esp32/src/tasks.cpp
@@ -33,8 +33,10 @@ volatile bool eventQueueFlag;
 void tcpip_message_handler(void*)
 {
 	eventQueueFlag = false;
+	// Process only waiting messages (not newly posted ones) so tcpip doesn't starve
+	auto messageCount = uxQueueMessagesWaiting(eventQueue);
 	os_event_t evt;
-	while(xQueueReceive(eventQueue, &evt, 0) == pdTRUE) {
+	while(messageCount-- && xQueueReceive(eventQueue, &evt, 0) == pdTRUE) {
 		taskCallback(&evt);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,10 @@ volatile bool eventQueueFlag;`
`33`	`33`	`void tcpip_message_handler(void*)`
`34`	`34`	`{`
`35`	`35`	`eventQueueFlag = false;`
	`36`	`+ // Process only waiting messages (not newly posted ones) so tcpip doesn't starve`
	`37`	`+ auto messageCount = uxQueueMessagesWaiting(eventQueue);`
`36`	`38`	`os_event_t evt;`
`37`		`- while(xQueueReceive(eventQueue, &evt, 0) == pdTRUE) {`
	`39`	`+ while(messageCount-- && xQueueReceive(eventQueue, &evt, 0) == pdTRUE) {`
`38`	`40`	`taskCallback(&evt);`
`39`	`41`	`}`
`40`	`42`	`}`