Skip to content

Commit 011ddda

Browse files
committed
http2,tests: undo changes related to ExampleServer
1 parent 0021992 commit 011ddda

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

helper/http2/http2.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,6 @@ func (srv *Server) serveConn(baseCtx context.Context, conn net.Conn) error {
187187
}
188188
}
189189

190-
// Close closes the server by closing all listeners.
191-
func (srv *Server) Close() error {
192-
return srv.closeListeners()
193-
}
194-
195190
func (srv *Server) closeListeners() error {
196191
srv.mu.Lock()
197192
defer srv.mu.Unlock()

helper/http2/http2_test.go

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
)
2222

2323
func ExampleServer() {
24-
ln, err := net.Listen("tcp", "localhost:0")
24+
ln, err := net.Listen("tcp", "localhost:80")
2525
if err != nil {
2626
log.Fatalf("failed to listen: %v", err)
2727
}
@@ -36,20 +36,9 @@ func ExampleServer() {
3636
_, _ = w.Write([]byte("Hello world!\n"))
3737
}),
3838
}, nil)
39-
// Run the server in a goroutine.
40-
go func() {
41-
if err := server.Serve(proxyLn); err != nil && !errors.Is(err, http.ErrServerClosed) {
42-
log.Fatalf("failed to serve: %v", err)
43-
}
44-
}()
45-
46-
time.Sleep(1 * time.Second)
47-
48-
if err := server.Close(); err != nil {
49-
log.Fatalf("failed to close server: %v", err)
39+
if err := server.Serve(proxyLn); err != nil {
40+
log.Fatalf("failed to serve: %v", err)
5041
}
51-
52-
// Output:
5342
}
5443

5544
type contextKey string

0 commit comments

Comments
 (0)