Fix is-server being ignored in stun-multiplex

Call `flag.Parse()` first to enable normal reading
of parameters

Author: gongluck

cmd/stun-multiplex/main.go

@@ -85,10 +85,10 @@ func multiplex(conn *net.UDPConn, stunAddr net.Addr, stunConn io.Reader) {
 var stunServer = flag.String("stun", "stun.l.google.com:19302", "STUN Server to use") //nolint:gochecknoglobals
 
 func main() {
-	isServer := flag.Arg(0) == ""
-
 	flag.Parse()
 
+	isServer := flag.Arg(0) == ""
+
 	// Allocating local UDP socket that will be used both for STUN and
 	// our application data.
 	addr, err := net.ResolveUDPAddr("udp4", "0.0.0.0:0")

integrity.go

@@ -20,8 +20,8 @@ const credentialsSep = ":"
 // credentials. Password, username, and realm must be SASL-prepared.
 func NewLongTermIntegrity(username, realm, password string) MessageIntegrity {
 	k := strings.Join([]string{username, realm, password}, credentialsSep)
-	h := md5.New() //nolint:gosec
-	fmt.Fprint(h, k)
+	h := md5.New()   //nolint:gosec
+	fmt.Fprint(h, k) //nolint:errcheck
 	return MessageIntegrity(h.Sum(nil))
 }