Skip to content

Commit 4e82517

Browse files
committed
emit warnings on V8 < 6.5.143 also
1 parent 7482566 commit 4e82517

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The extension allows you to execute Javascript code in a secure sandbox from PHP
1212
can be restricted using a time limit and/or memory limit. This provides the possibility to execute
1313
untrusted code with confidence.
1414

15-
If you execute untrusted JavaScript code, make sure to **use V8 version 6.4.388.18 or higher**.
15+
If you execute untrusted JavaScript code, make sure to **use V8 version 6.4.388.18, 6.5.143 or higher**.
1616
See notes on [untrusted code mitigations](https://github.com/v8/v8/wiki/Untrusted-code-mitigations)
1717
for further details.
1818

config.m4

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ int main ()
147147
if test "$V8_API_VERSION" -lt 6004388 ; then
148148
AC_MSG_WARN([libv8 prior to 6.4.388.18 is missing speculative execution mitigations])
149149
fi
150+
if test "$V8_API_VERSION" -ge 6005000 -a "$V8_API_VERSION" -lt 6005143 ; then
151+
AC_MSG_WARN([libv8 6.5.x prior to 6.5.143 is missing speculative execution mitigations])
152+
fi
150153
AC_DEFINE_UNQUOTED([PHP_V8_API_VERSION], $V8_API_VERSION, [ ])
151154
AC_DEFINE_UNQUOTED([PHP_V8_VERSION], "$ac_cv_v8_version", [ ])
152155
else

0 commit comments

Comments
 (0)