Explicitly check ON DUPLICATE KEY UPDATE and adding a test case

Signed-off-by: Fawzi E. Abdulfattah <[email protected]>

Author: iifawzi

src/Statements/WithStatement.php

@@ -216,12 +216,22 @@ public function parse(Parser $parser, TokensList $list)
                 if ($list->getNextOfTypeAndValue(Token::TYPE_KEYWORD, 'ON')) {
                     // (-1) because getNextOfTypeAndValue returned ON and increased the index.
                     $idxOfOn = $list->idx - 1;
-                    // Index of the last parsed token will be the token before the ON Keyword, therefore $idxOfOn - 1.
-                    $idxOfLastParsedToken = $idxOfOn - 1;
-                    // The length of the expression tokens would be the difference
-                    // between the first unrelated token `ON` and the idx
-                    // before skipping the CTE tokens.
-                    $lengthOfExpressionTokens = $idxOfOn - $idxBeforeSearch;
+                    // We want to make sure that it's `ON DUPLICATE KEY UPDATE`
+                    $dubplicateToken = $list->getNext();
+                    $keyToken = $list->getNext();
+                    $updateToken = $list->getNext();
+                    if (
+                        $dubplicateToken && $dubplicateToken->keyword === 'DUPLICATE'
+                        && ($keyToken && $keyToken->keyword === 'KEY')
+                        && ($updateToken && $updateToken->keyword === 'UPDATE')
+                    ) {
+                        // Index of the last parsed token will be the token before the ON Keyword
+                        $idxOfLastParsedToken = $idxOfOn - 1;
+                        // The length of the expression tokens would be the difference
+                        // between the first unrelated token `ON` and the idx
+                        // before skipping the CTE tokens.
+                        $lengthOfExpressionTokens = $idxOfOn - $idxBeforeSearch;
+                    }
                 }
 
                 // Restore the index

tests/Parser/WithStatementTest.php

@@ -33,6 +33,7 @@ public function parseWith(): array
             ['parser/parseWithStatement4'],
             ['parser/parseWithStatement5'],
             ['parser/parseWithStatement6'],
+            ['parser/parseWithStatement7'],
             ['parser/parseWithStatementErr'],
             ['parser/parseWithStatementErr1'],
             ['parser/parseWithStatementErr2'],

tests/data/parser/parseWithStatement7.in

@@ -0,0 +1 @@
+WITH cte (col1) AS ( SELECT 1 UNION ALL SELECT 2 ) SELECT * FROM cte INNER JOIN table2 ON table2.col1=cte.col1;