Fix ParameterDefinition::build

Signed-off-by: Kamil Tekiela <[email protected]>

Author: kamil-tekiela

phpstan-baseline.neon

@@ -335,11 +335,6 @@ parameters:
 			count: 2
 			path: src/Components/OrderKeyword.php
 
-		-
-			message: "#^Parameter \\#1 \\$component of static method PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:build\\(\\) expects array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>, \\$this\\(PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\) given\\.$#"
-			count: 1
-			path: src/Components/ParameterDefinition.php
-
 		-
 			message: "#^Property PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:\\$inOut \\(string\\) does not accept string\\|null\\.$#"
 			count: 1
@@ -365,11 +360,6 @@ parameters:
 			count: 2
 			path: src/Components/ParameterDefinition.php
 
-		-
-			message: "#^Unreachable statement \\- code above always terminates\\.$#"
-			count: 1
-			path: src/Components/ParameterDefinition.php
-
 		-
 			message: "#^Property PhpMyAdmin\\\\SqlParser\\\\Components\\\\PartitionDefinition\\:\\:\\$expr \\(PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\|string\\) does not accept PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\|null\\.$#"
 			count: 1
@@ -596,7 +586,7 @@ parameters:
 			path: src/Statements/CreateStatement.php
 
 		-
-			message: "#^Parameter \\#1 \\$component of static method PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:build\\(\\) expects array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>, array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|null given\\.$#"
+			message: "#^Parameter \\#1 \\$component of static method PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:build\\(\\) expects array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition, array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|null given\\.$#"
 			count: 1
 			path: src/Statements/CreateStatement.php
 
@@ -966,7 +956,7 @@ parameters:
 			path: tests/Builder/CreateStatementTest.php
 
 		-
-			message: "#^Parameter \\#1 \\$component of static method PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:build\\(\\) expects array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>, array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|null given\\.$#"
+			message: "#^Parameter \\#1 \\$component of static method PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\:\\:build\\(\\) expects array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition, array\\<PhpMyAdmin\\\\SqlParser\\\\Components\\\\ParameterDefinition\\>\\|null given\\.$#"
 			count: 2
 			path: tests/Builder/CreateStatementTest.php
 

psalm-baseline.xml

@@ -491,24 +491,9 @@
     </PossiblyNullPropertyAssignmentValue>
   </file>
   <file src="src/Components/ParameterDefinition.php">
-    <InvalidArgument>
-      <code>$this</code>
-    </InvalidArgument>
-    <MixedArgument>
-      <code><![CDATA[$component->name]]></code>
-    </MixedArgument>
     <MixedAssignment>
       <code><![CDATA[$expr->name]]></code>
     </MixedAssignment>
-    <MixedOperand>
-      <code><![CDATA[$component->inOut]]></code>
-      <code><![CDATA[$component->type]]></code>
-    </MixedOperand>
-    <MixedPropertyFetch>
-      <code><![CDATA[$component->inOut]]></code>
-      <code><![CDATA[$component->name]]></code>
-      <code><![CDATA[$component->type]]></code>
-    </MixedPropertyFetch>
     <MoreSpecificImplementedParamType>
       <code>$component</code>
     </MoreSpecificImplementedParamType>
@@ -519,7 +504,6 @@
       <code>DataType::parse($parser, $list)</code>
     </PossiblyNullPropertyAssignmentValue>
     <RedundantConditionGivenDocblockType>
-      <code>is_array($component)</code>
       <code><![CDATA[isset($expr->name)]]></code>
     </RedundantConditionGivenDocblockType>
   </file>

src/Components/ParameterDefinition.php

@@ -141,8 +141,8 @@ public static function parse(Parser $parser, TokensList $list, array $options =
     }
 
     /**
-     * @param ParameterDefinition[] $component the component to be built
-     * @param array<string, mixed>  $options   parameters for building
+     * @param ParameterDefinition[]|ParameterDefinition $component the component to be built
+     * @param array<string, mixed>                      $options   parameters for building
      */
     public static function build($component, array $options = []): string
     {