From 98ce3630392f85d14a8fa2b4ff4f004aa2c44d6c Mon Sep 17 00:00:00 2001
From: Christiaan <anotherhero@gmail.com>
Date: Mon, 12 Aug 2013 10:26:43 +0200
Subject: [PATCH] Type Hinting improvements

---
 src/Phpforce/SoapClient/BulkSaver.php                    | 3 +--
 src/Phpforce/SoapClient/Result/DescribeGlobalResult.php  | 1 +
 src/Phpforce/SoapClient/Result/DescribeSObjectResult.php | 3 ++-
 src/Phpforce/SoapClient/Result/SaveResult.php            | 2 +-
 src/Phpforce/SoapClient/Soap/SoapClientFactory.php       | 8 ++++----
 5 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/Phpforce/SoapClient/BulkSaver.php b/src/Phpforce/SoapClient/BulkSaver.php
index f1a368e..b34a198 100644
--- a/src/Phpforce/SoapClient/BulkSaver.php
+++ b/src/Phpforce/SoapClient/BulkSaver.php
@@ -2,8 +2,7 @@
 
 namespace Phpforce\SoapClient;
 
-use Phpforce\SoapClient\Client;
-use Phpforce\SoapClient\Response\SaveResult;
+use Phpforce\SoapClient\Result\SaveResult;
 
 /**
  * Add creates, updates and upserts to the queue, and issue them in bulk to
diff --git a/src/Phpforce/SoapClient/Result/DescribeGlobalResult.php b/src/Phpforce/SoapClient/Result/DescribeGlobalResult.php
index c3d5c80..bf67fbd 100644
--- a/src/Phpforce/SoapClient/Result/DescribeGlobalResult.php
+++ b/src/Phpforce/SoapClient/Result/DescribeGlobalResult.php
@@ -6,5 +6,6 @@ class DescribeGlobalResult
 {
     public $encoding;
     public $maxBatchSize;
+    /** @var DescribeGlobalSObjectResult[] */
     public $sobjects = array();
 }
\ No newline at end of file
diff --git a/src/Phpforce/SoapClient/Result/DescribeSObjectResult.php b/src/Phpforce/SoapClient/Result/DescribeSObjectResult.php
index 25e5ae2..cc030df 100644
--- a/src/Phpforce/SoapClient/Result/DescribeSObjectResult.php
+++ b/src/Phpforce/SoapClient/Result/DescribeSObjectResult.php
@@ -3,6 +3,7 @@
 namespace Phpforce\SoapClient\Result;
 
 use Doctrine\Common\Collections\ArrayCollection;
+use Phpforce\SoapClient\Result\DescribeSObjectResult\Field;
 
 class DescribeSObjectResult
 {
@@ -111,7 +112,7 @@ public function isFeedEnabled()
 
     /**
      *
-     * @return ArrayCollection
+     * @return ArrayCollection|Field[]
      */
     public function getFields()
     {
diff --git a/src/Phpforce/SoapClient/Result/SaveResult.php b/src/Phpforce/SoapClient/Result/SaveResult.php
index 91ed151..93224a3 100644
--- a/src/Phpforce/SoapClient/Result/SaveResult.php
+++ b/src/Phpforce/SoapClient/Result/SaveResult.php
@@ -53,7 +53,7 @@ public function isSuccess()
     }
 
     /**
-     * @return array
+     * @return Error[]
      */
     public function getErrors()
     {
diff --git a/src/Phpforce/SoapClient/Soap/SoapClientFactory.php b/src/Phpforce/SoapClient/Soap/SoapClientFactory.php
index 0bc88b2..389c937 100644
--- a/src/Phpforce/SoapClient/Soap/SoapClientFactory.php
+++ b/src/Phpforce/SoapClient/Soap/SoapClientFactory.php
@@ -46,14 +46,14 @@ class SoapClientFactory
     /**
      * Type converters collection
      *
-     * @var TypeConverterCollection
+     * @var TypeConverter\TypeConverterCollection
      */
     protected $typeConverters;
 
     /**
      * @param string $wsdl Some argument description
      *
-     * @return void
+     * @return SoapClient
      */
     public function factory($wsdl)
     {
@@ -80,7 +80,7 @@ public function setClassmapping($soap, $php)
     /**
      * Get type converter collection that will be used for the \SoapClient
      *
-     * @return TypeConverterCollection
+     * @return TypeConverter\TypeConverterCollection
      */
     public function getTypeConverters()
     {
@@ -99,7 +99,7 @@ public function getTypeConverters()
     /**
      * Set type converter collection
      *
-     * @param type $typeConverters Type converter collection
+     * @param TypeConverter\TypeConverterCollection $typeConverters Type converter collection
      *
      * @return SoapClientFactory
      */