code style fixes

Author: voku

src/TypeResolver.php

@@ -485,6 +485,7 @@ private function resolveClassString(ArrayIterator $tokens, Context $context): ar
         }
 
         if ($aggreatedObjects) {
+            assert($classType instanceof AggregatedType);
             foreach ($classType->getIterator() as $typeInner) {
                 if (!$typeInner instanceof Object_ || $typeInner->getFqsen() === null) {
                     throw new RuntimeException(
@@ -515,10 +516,13 @@ private function resolveClassString(ArrayIterator $tokens, Context $context): ar
 
         $return = [];
         if ($aggreatedObjects) {
+            assert($classType instanceof AggregatedType);
             foreach ($classType->getIterator() as $typeInner) {
+                assert($typeInner instanceof Object_);
                 $return[] = new ClassString($typeInner->getFqsen());
             }
         } else {
+            assert($classType instanceof Object_);
             $return[] = new ClassString($classType->getFqsen());
         }
 

src/Types/AbstractList.php

@@ -15,6 +15,9 @@
 
 use phpDocumentor\Reflection\Type;
 
+use function count;
+use function implode;
+
 /**
  * Represents a list of values. This is an abstract class for Array_ and Collection.
  *
@@ -67,16 +70,21 @@ public function getValueType(): Type
     public function __toString(): string
     {
         if ($this->keyType) {
-
             $classStringValues = [];
             if ($this->valueType instanceof AggregatedType) {
+                /**
+                 * @psalm-suppress ImpureMethodCall
+                 */
                 foreach ($this->valueType->getIterator() as $typeInner) {
-                    if (!$typeInner instanceof ClassString) {
+                    if ($typeInner instanceof ClassString) {
+                        $fqsenTmp = $typeInner->getFqsen();
+                        if ($fqsenTmp) {
+                            $classStringValues[] = $fqsenTmp->__toString();
+                        }
+                    } else {
                         $classStringValues = [];
                         break;
                     }
-
-                    $classStringValues[] = $typeInner->getFqsen()->__toString();
                 }
             }
             if (count($classStringValues) > 0) {

tests/unit/ClassStringResolverTest.php

@@ -13,8 +13,11 @@
 
 namespace phpDocumentor\Reflection;
 
-use phpDocumentor\Reflection\PseudoTypes\IntegerRange;
+use phpDocumentor\Reflection\Types\Array_;
+use phpDocumentor\Reflection\Types\ClassString;
+use phpDocumentor\Reflection\Types\Compound;
 use phpDocumentor\Reflection\Types\Context;
+use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -37,15 +40,15 @@ public function testResolvingClassString(): void
 
         $resolvedType = $fixture->resolve('array<int,class-string<\Foo\Bar>>', new Context(''));
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\Array_::class, $resolvedType);
+        $this->assertInstanceOf(Array_::class, $resolvedType);
         $this->assertSame('array<int,class-string<\Foo\Bar>>', (string) $resolvedType);
 
         $keyType = $resolvedType->getKeyType();
         $valueTpye = $resolvedType->getValueType();
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\Integer::class, $keyType);
+        $this->assertInstanceOf(Integer::class, $keyType);
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\ClassString::class, $valueTpye);
+        $this->assertInstanceOf(ClassString::class, $valueTpye);
         $this->assertSame('Bar', $valueTpye->getFqsen()->getName());
         $this->assertSame('\Foo\Bar', $valueTpye->getFqsen()->__toString());
     }
@@ -64,18 +67,17 @@ public function testResolvingClassStrings(): void
 
         $resolvedType = $fixture->resolve('array<int,class-string<\Foo\Bar|\Foo\Lall>>', new Context(''));
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\Array_::class, $resolvedType);
+        $this->assertInstanceOf(Array_::class, $resolvedType);
         $this->assertSame('array<int,class-string<\Foo\Bar|\Foo\Lall>>', (string) $resolvedType);
 
         $keyType = $resolvedType->getKeyType();
         $valueTpye = $resolvedType->getValueType();
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\Integer::class, $keyType);
+        $this->assertInstanceOf(Integer::class, $keyType);
 
-        $this->assertInstanceOf(\phpDocumentor\Reflection\Types\Compound::class, $valueTpye);
+        $this->assertInstanceOf(Compound::class, $valueTpye);
         foreach ($valueTpye->getIterator() as $type) {
-            $this->assertInstanceOf(\phpDocumentor\Reflection\Types\ClassString::class, $type);
+            $this->assertInstanceOf(ClassString::class, $type);
         }
     }
-
 }