From f0160cd14548f5dc8d11b4730e833f0fcc247fc1 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Fri, 30 Dec 2022 16:03:40 +0100 Subject: [PATCH] Fix variation5-win32(-mb).phpt wrt. parallel test execution Each test should use its own temporary filenames to avoid issues when the tests are executed in parallel[1]. We also silence the `unlink()` calls in the CLEAN section just in case. And while we're at it, we also remove the erroneous comment; there is no symlinking involved for the Windows test variants. [1] --- ext/standard/tests/file/file_variation5-win32-mb.phpt | 6 +++--- ext/standard/tests/file/file_variation5-win32.phpt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ext/standard/tests/file/file_variation5-win32-mb.phpt b/ext/standard/tests/file/file_variation5-win32-mb.phpt index 18dd399e5b7a9..0e6bbd69e33d0 100644 --- a/ext/standard/tests/file/file_variation5-win32-mb.phpt +++ b/ext/standard/tests/file/file_variation5-win32-mb.phpt @@ -14,7 +14,7 @@ chdir($script_directory); $test_dirname = basename(__FILE__, ".php") . "私はガラスを食べられますtestdir"; mkdir($test_dirname); -$filepath = __DIR__ . '/file_variation_5.tmp'; +$filepath = __DIR__ . '/file_variation_5_mb.tmp'; $filename = basename($filepath); $fd = fopen($filepath, "w+"); fwrite($fd, "Line 1\nLine 2\nLine 3"); @@ -35,8 +35,8 @@ chdir($script_directory); --CLEAN-- --EXPECT-- diff --git a/ext/standard/tests/file/file_variation5-win32.phpt b/ext/standard/tests/file/file_variation5-win32.phpt index cde34d83c53f3..948f56e034720 100644 --- a/ext/standard/tests/file/file_variation5-win32.phpt +++ b/ext/standard/tests/file/file_variation5-win32.phpt @@ -36,7 +36,7 @@ chdir($script_directory); --EXPECT--