Update last stub infos based on nikis comments.

Author: beberlei

ext/dom/dom.stub.php

@@ -260,10 +260,11 @@ public function getFeature(string $feature, string $version) {}
     /** @return bool */
     public function hasFeature(string $feature, string $version) {}
 
+    /** @return DOMDocumentType|false */
     public function createDocumentType($qualifiedName, $publicId, $systemId) {}
 
     /** @return DOMDocument|false */
-    public function createDocument(?string $namespaceURI = null, ?string $qualifiedName = null, ?DOMDocumentType $doctype = null) {}
+    public function createDocument(string $namespaceURI = "", string $qualifiedName = "", DOMDocumentType $doctype = UNKNOWN) {}
 }
 
 class DOMNamedNodeMap {
@@ -323,4 +324,7 @@ public function registerPhpFunctions($restrict = null) {}
 }
 #endif
 
+class DOMDocumentType {
+}
+
 function dom_import_simplexml(object $node): ?DOMElement {}

ext/dom/dom_arginfo.h

@@ -329,9 +329,9 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_class_DOMImplementation_createDocumentType, 0, 0,
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_DOMImplementation_createDocument, 0, 0, 0)
-	ZEND_ARG_TYPE_INFO(0, namespaceURI, IS_STRING, 1)
-	ZEND_ARG_TYPE_INFO(0, qualifiedName, IS_STRING, 1)
-	ZEND_ARG_OBJ_INFO(0, doctype, DOMDocumentType, 1)
+	ZEND_ARG_TYPE_INFO(0, namespaceURI, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, qualifiedName, IS_STRING, 0)
+	ZEND_ARG_OBJ_INFO(0, doctype, DOMDocumentType, 0)
 ZEND_END_ARG_INFO()
 
 #define arginfo_class_DOMNamedNodeMap_getNamedItem arginfo_class_DOMDocument_createAttribute

ext/dom/domimplementation.c

@@ -73,7 +73,7 @@ PHP_METHOD(domimplementation, createDocumentType)
 	xmlChar *pch1 = NULL, *pch2 = NULL, *localname = NULL;
 	xmlURIPtr uri;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "|sss", &name, &name_len, &publicid, &publicid_len, &systemid, &systemid_len) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "s|ss", &name, &name_len, &publicid, &publicid_len, &systemid, &systemid_len) == FAILURE) {
 		return;
 	}
 
@@ -139,7 +139,7 @@ PHP_METHOD(domimplementation, createDocument)
 	char *prefix = NULL, *localname = NULL;
 	dom_object *doctobj;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "|ssO", &uri, &uri_len, &name, &name_len, &node, dom_documenttype_class_entry) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "|ssO!", &uri, &uri_len, &name, &name_len, &node, dom_documenttype_class_entry) == FAILURE) {
 		return;
 	}