Skip to content

Commit 7746815

Browse files
committed
Use zend_string_equals() API instead of strcmp() in Filter extension
1 parent d49b71c commit 7746815

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/filter/logical_filters.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ void php_filter_validate_url(PHP_INPUT_FILTER_PARAM_DECL) /* {{{ */
627627
if (
628628
url->scheme == NULL ||
629629
/* some schemas allow the host to be empty */
630-
(url->host == NULL && (strcmp(ZSTR_VAL(url->scheme), "mailto") && strcmp(ZSTR_VAL(url->scheme), "news") && strcmp(ZSTR_VAL(url->scheme), "file"))) ||
630+
(url->host == NULL && (!zend_string_equals_literal(url->scheme, "mailto") && !zend_string_equals_literal(url->scheme, "news") && !zend_string_equals_literal(url->scheme, "file"))) ||
631631
((flags & FILTER_FLAG_PATH_REQUIRED) && url->path == NULL) || ((flags & FILTER_FLAG_QUERY_REQUIRED) && url->query == NULL)
632632
) {
633633
bad_url:
@@ -902,12 +902,12 @@ void php_filter_validate_ip(PHP_INPUT_FILTER_PARAM_DECL) /* {{{ */
902902
case 1: case 0:
903903
break;
904904
case 2:
905-
if (!strcmp("::", Z_STRVAL_P(value))) {
905+
if (zend_string_equals_literal(Z_STR_P(value), "::")) {
906906
RETURN_VALIDATION_FAILED
907907
}
908908
break;
909909
case 3:
910-
if (!strcmp("::1", Z_STRVAL_P(value)) || !strcmp("5f:", Z_STRVAL_P(value))) {
910+
if (zend_string_equals_literal(Z_STR_P(value), "::1") || zend_string_equals_literal(Z_STR_P(value), "5f:")) {
911911
RETURN_VALIDATION_FAILED
912912
}
913913
break;

0 commit comments

Comments
 (0)