Make all private fields/methods protected to provide better expandability

Author: pfcode

src/Storage/LocalStorage.php

@@ -11,11 +11,11 @@ class LocalStorage implements StorageInterface
     /**
      * @var string
      */
-    private $absolutePath;
+    protected $absolutePath;
     /**
      * @var string
      */
-    private $baseUrl;
+    protected $baseUrl;
 
     /**
      * LocalStorage constructor.
@@ -156,7 +156,7 @@ public function removeAttachment(AttachmentInterface $attachment): void {
      * @param AttachmentInterface $attachment
      * @return string
      */
-    private function getAttachmentFileName(AttachmentInterface $attachment): ?string {
+    protected function getAttachmentFileName(AttachmentInterface $attachment): ?string {
         $ext = trim($attachment->getExtension());
         $slug = trim($attachment->getSlug());
 
@@ -175,7 +175,7 @@ private function getAttachmentFileName(AttachmentInterface $attachment): ?string
      * @param string $path
      * @param AttachmentInterface $attachment
      */
-    private function updateAttachmentInfo(string $path, AttachmentInterface $attachment): void {
+    protected function updateAttachmentInfo(string $path, AttachmentInterface $attachment): void {
         $attachment->setFileSize((int)filesize($path));
         $attachment->setMimeType(mime_content_type($path));
         $attachment->setStorageIdentifier($this->getStorageIdentifier());

src/StorageRegistry/StorageRegistry.php

@@ -8,13 +8,13 @@
 class StorageRegistry
 {
     /** @var StorageInterface[] */
-    private $registeredStorageServicesByClass = [];
+    protected $registeredStorageServicesByClass = [];
 
     /** @var StorageInterface[] */
-    private $registeredStorageServicesByIdentifiers = [];
+    protected $registeredStorageServicesByIdentifiers = [];
 
     /** @var StorageInterface|null */
-    private $defaultStorage;
+    protected $defaultStorage;
 
     /**
      * @param StorageInterface $storage

src/Uploader/AttachmentUploader.php

@@ -19,19 +19,19 @@
 class AttachmentUploader
 {
     /** @var StorageRegistry */
-    private $storageRegistry;
+    protected $storageRegistry;
 
     /** @var string */
-    private $entityClass;
+    protected $entityClass;
 
     /** @var ExtensionSuggester */
-    private $extensionSuggester;
+    protected $extensionSuggester;
 
     /** @var SlugGeneratorInterface */
-    private $slugGenerator;
+    protected $slugGenerator;
 
     /** @var DownloaderInterface */
-    private $downloader;
+    protected $downloader;
 
     /**
      * AttachmentRepository constructor.

src/Utils/SlugGenerator/SampleSlugGenerator.php

@@ -13,13 +13,13 @@ class SampleSlugGenerator implements SlugGeneratorInterface
     public const MAX_DUPLICATION_CHECKS = 10;
 
     /** @var ObjectRepository */
-    private $repository;
+    protected $repository;
 
     /** @var int */
-    private $slugLength;
+    protected $slugLength;
 
     /** @var string */
-    private $slugColumn;
+    protected $slugColumn;
 
     /**
      * SampleSlugGenerator constructor.
@@ -61,7 +61,7 @@ public function generate(?AttachmentInterface $attachment = null): ?string {
      * @return string
      * @throws SlugGeneratorException
      */
-    private function randomAlphanumericString($length): string {
+    protected function randomAlphanumericString($length): string {
         $allowedCharacters = '0123456789abcdefghijklmnopqrstuvwxyz';
         $repeats = max(ceil($length / strlen($allowedCharacters)), 1);
         $str = substr(str_shuffle(str_repeat($allowedCharacters, $repeats)), 0, $length);