feat: Support VeloxQueryRunner in Github Expression Fuzzer (facebookincubator#15483)

Summary:
Pull Request resolved: facebookincubator#15483

Add Regression Fuzzer (i.e. Expression Fuzzer with LocalRunnerService as a source-of-truth) to Fuzzer Job test suite. This fuzzer sends serialized plans to a thrift service build on the base commit to test solely on new changes.

Differential Revision: D86911550

Author: peterenescu

.github/workflows/linux-build-base.yml

@@ -105,6 +105,7 @@ jobs:
             "-DVELOX_ENABLE_WAVE=ON"
             "-DVELOX_MONO_LIBRARY=ON"
             "-DVELOX_BUILD_SHARED=ON"
+            "-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON"
           )
           if [[ "${USE_CLANG}" = "true" ]]; then
              scripts/setup-centos9.sh install_clang15; export CC=/usr/bin/clang-15; export CXX=/usr/bin/clang++-15; CUDA_FLAGS="-ccbin /usr/lib64/llvm15/bin/clang++-15";

.github/workflows/scheduled.yml

@@ -222,6 +222,7 @@ jobs:
             -DVELOX_MONO_LIBRARY=ON
             -DVELOX_BUILD_PYTHON_PACKAGE=ON
             -DVELOX_PYTHON_LEGACY_ONLY=ON
+            -DVELOX_ENABLE_REMOTE_FUNCTIONS=ON
             ${{ inputs.extraCMakeFlags }}
         run: |
           make python-venv
@@ -383,6 +384,13 @@ jobs:
           path: velox/_build/debug/velox/exec/fuzzer/velox_spatial_join_fuzzer
           retention-days: ${{ env.RETENTION }}
 
+      - name: Upload local runner service runner
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: local_runner_service_runner
+          path: velox/_build/debug/velox/exec/fuzzer/velox_local_runner_service_runner
+          retention-days: ${{ env.RETENTION }}
+
   presto-fuzzer-run:
     name: Presto Fuzzer
     if: ${{ needs.compile.outputs.presto_bias  != 'true' }}
@@ -459,6 +467,95 @@ jobs:
           path: |
             /tmp/fuzzer_repro
 
+  presto-fuzzer-with-local-runner-run:
+    name: Presto Fuzzer with Local Runner
+    runs-on: ubuntu-latest
+    container: ghcr.io/facebookincubator/velox-dev:centos9
+    needs: compile
+    timeout-minutes: 120
+    steps:
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        if: github.event_name == 'pull_request'
+        id: changes
+        with:
+          filters: |
+            presto:
+              - 'velox/expression/!(test)**'
+              - 'velox/exec/!(test)**'
+              - 'velox/common/!(test)**'
+              - 'velox/core/!(test)**'
+              - 'velox/vector/!(test)**'
+
+      - name: Set presto specific fuzzer duration
+        env:
+          # Run for 30 minutes instead of 15, when files relevant to presto are touched
+          pr_duration: ${{ steps.changes.outputs.presto == 'true' && 1800 || 900 }}
+          # Run for 60 minutes if its a scheduled run
+          other_duration: ${{ inputs.duration || (github.event_name == 'push' && 1800 || 3600) }}
+          is_pr: ${{ github.event_name == 'pull_request' }}
+        run: |
+          if [ "$is_pr" == "true" ]; then
+            duration=$pr_duration
+          else
+            duration=$other_duration
+          fi
+
+          echo "DURATION=$duration" >> $GITHUB_ENV
+
+      - name: Download presto fuzzer
+        uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
+        with:
+          name: presto
+
+      - name: Download local runner service runner
+        uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
+        with:
+          name: local_runner_service_runner
+
+      - name: Run Presto Fuzzer with Local Runner
+        run: |
+          mkdir -p /tmp/fuzzer_repro/logs/
+          chmod -R 777 /tmp/fuzzer_repro
+          chmod +x velox_expression_fuzzer_test
+          chmod +x velox_local_runner_service_runner
+          # Start LocalRunnerService in the background
+          ./velox_local_runner_service_runner > /tmp/fuzzer_repro/logs/local_runner_service.log 2>&1 &
+          LOCAL_RUNNER_PID=$!
+          echo "Started LocalRunnerService with PID: ${LOCAL_RUNNER_PID}"
+          # Sleep for 10 seconds to allow service to start
+          sleep 10
+          random_seed=${RANDOM}
+          echo "Random seed: ${random_seed}"
+          ./velox_expression_fuzzer_test \
+                --seed ${random_seed} \
+                --enable_variadic_signatures \
+                --velox_fuzzer_enable_complex_types \
+                --velox_fuzzer_enable_decimal_type \
+                --lazy_vector_generation_ratio 0.2 \
+                --common_dictionary_wraps_generation_ratio=0.3 \
+                --velox_fuzzer_enable_column_reuse \
+                --velox_fuzzer_enable_expression_reuse \
+                --max_expression_trees_per_step 2 \
+                --retry_with_try \
+                --enable_dereference \
+                --duration_sec $DURATION \
+                --minloglevel=0 \
+                --stderrthreshold=2 \
+                --log_dir=/tmp/fuzzer_repro/logs \
+                --repro_persist_path=/tmp/fuzzer_repro \
+                --local_runner_service_url=http://127.0.0.1:9091 \
+          && echo -e "\n\nFuzzer run finished successfully."
+          # Stop the LocalRunnerService
+          kill $LOCAL_RUNNER_PID || true
+
+      - name: Archive production artifacts
+        if: ${{ !cancelled() }}
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: presto-fuzzer-with-local-runner-failure-artifacts
+          path: |
+            /tmp/fuzzer_repro
+
   presto-sot-fuzzer-run:
     name: Expression Fuzzer with Presto SOT
     needs: compile

velox/exec/fuzzer/CMakeLists.txt

@@ -31,8 +31,7 @@ add_library(
 # ExpressionFuzzerTest. More information can be found here:
 # https://github.com/facebookincubator/velox/issues/15414
 if(VELOX_ENABLE_REMOTE_FUNCTIONS)
-  target_sources(velox_fuzzer_util PRIVATE VeloxQueryRunner.cpp)
-  target_link_libraries(velox_fuzzer_util FBThrift::thriftcpp2)
+  target_sources(velox_fuzzer_util VeloxQueryRunner.cpp)
 endif()
 
 target_link_libraries(
@@ -231,6 +230,9 @@ if(VELOX_ENABLE_REMOTE_FUNCTIONS)
 
   target_compile_options(local_runner_service_thrift PRIVATE -Wno-error=deprecated-declarations)
 
+  # Link velox_fuzzer_util with local_runner_service_thrift for VeloxQueryRunner
+  target_link_libraries(velox_fuzzer_util local_runner_service_thrift FBThrift::thriftcpp2)
+
   # LocalRunnerService Library
   add_library(velox_local_runner_service_lib LocalRunnerService.cpp)
 

velox/expression/fuzzer/ExpressionFuzzerTest.cpp

@@ -18,6 +18,7 @@
 #include <unordered_set>
 
 #include "velox/exec/fuzzer/PrestoQueryRunner.h"
+#include "velox/exec/fuzzer/VeloxQueryRunner.h"
 #include "velox/expression/fuzzer/ArgTypesGenerator.h"
 #include "velox/expression/fuzzer/ArgValuesGenerators.h"
 #include "velox/expression/fuzzer/ExpressionFuzzer.h"
@@ -46,6 +47,12 @@ DEFINE_string(
     "source of truth. Otherwise, use the Velox simplified expression evaluation. Example: "
     "--presto_url=http://127.0.0.1:8080");
 
+DEFINE_string(
+    local_runner_url,
+    "",
+    "URI for thrift requests to LocalRunnerService. Defaults to localhost on port 9091. "
+    "Example: --local_runner_url=http://127.0.0.1:9091");
+
 DEFINE_uint32(
     req_timeout_ms,
     10000,
@@ -461,6 +468,8 @@ std::unordered_set<std::string> skipFunctionsSOT = {
     "merge_khll(array(khyperloglog)) -> khyperloglog",
 };
 
+std::unordered_set<std::string> skipFunctionsLocalRunner = {};
+
 int main(int argc, char** argv) {
   ::testing::InitGoogleTest(&argc, argv);
 
@@ -480,6 +489,7 @@ int main(int argc, char** argv) {
   std::shared_ptr<facebook::velox::memory::MemoryPool> rootPool{
       facebook::velox::memory::memoryManager()->addRootPool()};
   std::shared_ptr<ReferenceQueryRunner> referenceQueryRunner{nullptr};
+  auto shouldAdjustTimestampToSessionTimezone = "true";
 
   if (!FLAGS_presto_url.empty()) {
     // Add additional functions to skip since we are now querying Presto
@@ -492,13 +502,23 @@ int main(int argc, char** argv) {
         "expression_fuzzer",
         static_cast<std::chrono::milliseconds>(FLAGS_req_timeout_ms));
     LOG(INFO) << "Using Presto as the reference DB.";
+  } else if (!FLAGS_local_runner_url.empty()) {
+    shouldAdjustTimestampToSessionTimezone = "false";
+    skipFunctions.insert(
+        skipFunctionsLocalRunner.begin(), skipFunctionsLocalRunner.end());
+    referenceQueryRunner = std::make_shared<VeloxQueryRunner>(
+        rootPool.get(),
+        FLAGS_local_runner_url,
+        std::chrono::milliseconds(FLAGS_req_timeout_ms));
+    LOG(INFO) << "Using LocalQueryRunner as the reference engine.";
   }
   FuzzerRunner::runFromGtest(
       initialSeed,
       skipFunctions,
       exprTransformers,
       {{"session_timezone", "America/Los_Angeles"},
-       {"adjust_timestamp_to_session_timezone", "true"}},
+       {"adjust_timestamp_to_session_timezone",
+        shouldAdjustTimestampToSessionTimezone}},
       argTypesGenerators,
       argValuesGenerators,
       referenceQueryRunner,