Merge pull request ppy#6528 from peppy/clean-up

Remove some obsoleted code

Author: smoogipoo

osu.Framework.SourceGeneration.Tests/AbstractGeneratorTests.cs

@@ -70,16 +70,16 @@ protected void GetTestSources(
             var commonGeneratedFiles = new List<(string filename, string content)>();
             var generatedFiles = new List<(string filename, string content)>();
 
-            foreach (string? file in resourceNames.Where(n => n.StartsWith(commonSourcesNamespace, StringComparison.Ordinal)))
+            foreach (string file in resourceNames.Where(n => n.StartsWith(commonSourcesNamespace, StringComparison.Ordinal)))
                 commonSourceFiles.Add((getFileNameFromResourceName(commonSourcesNamespace, file), readResourceStream(assembly, file)));
 
-            foreach (string? file in resourceNames.Where(n => n.StartsWith(commonGeneratedNamespace, StringComparison.Ordinal)))
+            foreach (string file in resourceNames.Where(n => n.StartsWith(commonGeneratedNamespace, StringComparison.Ordinal)))
                 commonGeneratedFiles.Add((getFileNameFromResourceName(commonGeneratedNamespace, file), readResourceStream(assembly, file)));
 
-            foreach (string? file in resourceNames.Where(n => n.StartsWith(sourcesNamespace, StringComparison.Ordinal)))
+            foreach (string file in resourceNames.Where(n => n.StartsWith(sourcesNamespace, StringComparison.Ordinal)))
                 sourceFiles.Add((getFileNameFromResourceName(sourcesNamespace, file), readResourceStream(assembly, file)));
 
-            foreach (string? file in resourceNames.Where(n => n.StartsWith(generatedNamespace, StringComparison.Ordinal)))
+            foreach (string file in resourceNames.Where(n => n.StartsWith(generatedNamespace, StringComparison.Ordinal)))
                 generatedFiles.Add((getFileNameFromResourceName(generatedNamespace, file), readResourceStream(assembly, file)));
 
             removeNameIndices(commonSourceFiles);

osu.Framework.SourceGeneration/Generators/Dependencies/Emitters/DependenciesFileEmitter.cs

@@ -142,10 +142,8 @@ private ExpressionSyntax emitInjectDependenciesDelegate()
                                 .WithBlock(
                                     SyntaxFactory.Block(
                                         Target.ResolvedMembers.Select(m => (IStatementEmitter)new ResolvedMemberEmitter(this, m))
-                                              .Concat(
-                                                  Target.DependencyLoaderMembers.Select(m => new BackgroundDependencyLoaderEmitter(this, m)))
-                                              .SelectMany(
-                                                  e => e.Emit())));
+                                              .Concat(Target.DependencyLoaderMembers.Select(m => new BackgroundDependencyLoaderEmitter(this, m)))
+                                              .SelectMany(e => e.Emit())));
         }
 
         private ExpressionSyntax emitCacheDependenciesDelegate()
@@ -172,8 +170,7 @@ private ExpressionSyntax emitCacheDependenciesDelegate()
                                                   Target.CachedClasses.Select(m => new CachedClassEmitter(this, m)))
                                               .Concat(
                                                   Target.CachedInterfaces.Select(m => new CachedInterfaceEmitter(this, m)))
-                                              .SelectMany(
-                                                  e => e.Emit())
+                                              .SelectMany(e => e.Emit())
                                               .Prepend(createPrologue())
                                               .Append(createEpilogue())));