chore: refine code

Author: stechio

pdfclown-common-build/src/main/java/org/pdfclown/common/build/test/assertion/Assertions.java

@@ -29,6 +29,7 @@ DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. If you reuse (enti
 import static org.pdfclown.common.build.internal.util_.Exceptions.runtime;
 import static org.pdfclown.common.build.internal.util_.Exceptions.unexpected;
 import static org.pdfclown.common.build.internal.util_.Exceptions.wrongArg;
+import static org.pdfclown.common.build.internal.util_.Objects.LITERAL_NULL;
 import static org.pdfclown.common.build.internal.util_.Objects.fqn;
 import static org.pdfclown.common.build.internal.util_.Objects.fqnd;
 import static org.pdfclown.common.build.internal.util_.Objects.objToLiteralString;
@@ -445,6 +446,8 @@ Matcher<T> getMatcher() {
    * @see Assertions#assertParameterized(Object, Expected, Supplier)
    */
   public static class ExpectedGeneration {
+    private static final int MAX_ARG_COMMENT_LENGTH__DEFAULT = 50;
+
     /**
      * Gets the constructor source code to use in {@link #setExpectedSourceCodeGenerator(Function)}.
      *
@@ -470,7 +473,7 @@ public static String expectedSourceCodeForFactory(Class<?> type, String methodNa
     Function<@Nullable Object, String> argCommentFormatter = Objects::objToLiteralString;
     final List<Entry<String, @Nullable Object>> args;
     Function<Object, String> expectedSourceCodeGenerator = Objects::objToLiteralString;
-    int maxArgCommentLength = 20;
+    int maxArgCommentLength = MAX_ARG_COMMENT_LENGTH__DEFAULT;
     PrintStream out = System.err;
     boolean outOverridable = true;
 
@@ -522,7 +525,7 @@ public Function<Object, String> getExpectedSourceCodeGenerator() {
     /**
      * Maximum length of argument values in comments accompanying expected results source code.
      * <p>
-     * DEFAULT: {@code 20}
+     * DEFAULT: {@value #MAX_ARG_COMMENT_LENGTH__DEFAULT}
      * </p>
      */
     public int getMaxArgCommentLength() {
@@ -758,11 +761,11 @@ protected ExpectedGenerator(int count) {
      * The expected result is mapped to source code representation based on its value type:
      * </p>
      * <ul>
-     * <li>{@code null} — to literal null ({@code "null"})</li>
      * <li>failed result (thrown {@link Throwable}) — to {@link Failure}</li>
      * <li>regular result — via
      * {@code generation.}{@link ExpectedGeneration#getExpectedSourceCodeGenerator()
      * expectedSourceCodeGenerator}</li>
+     * <li>{@code null} — to literal null ({@code "null"})</li>
      * </ul>
      *
      * @param expected
@@ -831,7 +834,7 @@ protected <T> void generateExpectedSourceCode(@Nullable Object expected,
         ExpectedGeneration generation) {
       String expectedSourceCode;
       if (expected == null) {
-        expectedSourceCode = "null";
+        expectedSourceCode = LITERAL_NULL;
       } else if (expected instanceof Failure) {
         var failure = (Failure) expected;
         expectedSourceCode = String.format("new %s(\"%s\", %s)",

pdfclown-common-build/src/test/java/org/pdfclown/common/build/test/assertion/AssertionsTest.java

@@ -213,7 +213,7 @@ void assertParameterized__cartesian_generation(Expected<String> expected, String
     doAssertParameterized_generation(expected, value, length, ""
         + "// expected\n"
         + "java.util.Arrays.asList(\n"
-        + "  // value[0]: \"The quick brow. . .\"\n"
+        + "  // value[0]: \"The quick brown fox jumps over the lazy dog\"\n"
         + "  // [1] length[0]: 50\n"
         + "  new org.pdfclown.common.build.test.assertion.Assertions.Failure("
         + "\"java.lang.IllegalArgumentException\", "
@@ -223,7 +223,7 @@ void assertParameterized__cartesian_generation(Expected<String> expected, String
         + "  // [3] length[2]: 5\n"
         + "  \"The q\",\n"
         + "  //\n"
-        + "  // value[1]: \"The lazy yello. . .\"\n"
+        + "  // value[1]: \"The lazy yellow dog was caught by the slow r. . .\"\n"
         + "  // [4] length[0]: 50\n"
         + "  \"The lazy yellow dog was caught by the slow red fox\",\n"
         + "  // [5] length[1]: 20\n"
@@ -256,11 +256,12 @@ void assertParameterized__simple_generation(Expected<String> expected, String va
     doAssertParameterized_generation(expected, value, length, ""
         + "// expected\n"
         + "java.util.Arrays.asList(\n"
-        + "  // [1] value[0]: \"The quick brow. . .\"; length[0]: 50\n"
+        + "  // [1] value[0]: \"The quick brown fox jumps over the lazy dog\"; length[0]: 50\n"
         + "  new org.pdfclown.common.build.test.assertion.Assertions.Failure("
         + "\"java.lang.IllegalArgumentException\", "
         + "\"`length` (50): INVALID (should be less than 43)\"),\n"
-        + "  // [2] value[1]: \"The lazy yello. . .\"; length[1]: 20\n"
+        + "  // [2] value[1]: \"The lazy yellow dog was caught by the slow r. . .\"; "
+        + "length[1]: 20\n"
         + "  \"The lazy yellow dog \"),\n");
   }
 

pdfclown-common-util/src/test/java/org/pdfclown/common/util/measure/UnitsTest.java

@@ -55,7 +55,7 @@ class UnitsTest extends BaseTest {
       .<Unit, String>comparing(Unit::getSymbol, Comparator.nullsFirst(String::compareToIgnoreCase))
       .thenComparing(Unit::getName);
 
-  private static final List<? super XtUnit<?>> units = Units.getInstance().getUnits().stream()
+  private static final List<? super XtUnit<?>> UNITS = Units.getInstance().getUnits().stream()
       .peek($ -> assertThat($, isA(XtUnit.class)))
       .map(XtUnit.class::cast)
       .sorted(COMPARATOR__UNIT)
@@ -156,7 +156,7 @@ static Stream<Arguments> getFactor_Unit() {
             1.0),
         // unit
         list()
-            .withAll(units)
+            .withAll(UNITS)
             .with(tech.units.indriya.unit.Units.WEEK)
             .with(tech.units.indriya.unit.Units.AMPERE));
   }
@@ -294,7 +294,7 @@ static Stream<Arguments> getOffset_Unit() {
             // [42] unit[41]: '℃ (Celsius)'
             273.15),
         // unit
-        units);
+        UNITS);
   }
 
   static Stream<Arguments> getQuantityType() {
@@ -388,7 +388,7 @@ static Stream<Arguments> getQuantityType() {
             // [42] unit[41]: '℃ (Celsius)'
             "javax.measure.quantity.Temperature"),
         // unit
-        units);
+        UNITS);
   }
 
   static Stream<Arguments> getQuantityType__external() {