Skip to content

Commit d49b5f3

Browse files
andrewor14pdeyhim
authored andcommitted
[Fix apache#204] Update out-dated comments
This PR is self-explanatory. Author: Andrew Or <[email protected]> Closes apache#381 from andrewor14/master and squashes the following commits: 3e8dde2 [Andrew Or] Fix comments for apache#204
1 parent e106cb1 commit d49b5f3

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

core/src/main/scala/org/apache/spark/SparkContext.scala

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,11 +1191,7 @@ class SparkContext(config: SparkConf) extends Logging {
11911191
listenerBus.post(SparkListenerApplicationStart(appName, startTime, sparkUser))
11921192
}
11931193

1194-
/**
1195-
* Post the application end event to all listeners immediately, rather than adding it
1196-
* to the event queue for it to be asynchronously processed eventually. Otherwise, a race
1197-
* condition exists in which the listeners may stop before this event has been propagated.
1198-
*/
1194+
/** Post the application end event */
11991195
private def postApplicationEnd() {
12001196
listenerBus.post(SparkListenerApplicationEnd(System.currentTimeMillis))
12011197
}

core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import org.apache.spark.util.JsonProtocol
3131
/**
3232
* A SparkListenerBus that replays logged events from persisted storage.
3333
*
34-
* This class expects files to be appropriately prefixed as specified in EventLoggingListener.
35-
* There exists a one-to-one mapping between ReplayListenerBus and event logging applications.
34+
* This assumes the given paths are valid log files, where each line can be deserialized into
35+
* exactly one SparkListenerEvent.
3636
*/
3737
private[spark] class ReplayListenerBus(
3838
logPaths: Seq[Path],

0 commit comments

Comments
 (0)