Skip to content

Commit 3914dc3

Browse files
committed
fix(Text input): Added aria-expanded
1 parent 7767e6a commit 3914dc3

File tree

15 files changed

+82
-0
lines changed

15 files changed

+82
-0
lines changed

packages/react-core/src/components/ClipboardCopy/__tests__/Generated/__snapshots__/ClipboardCopy.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ exports[`ClipboardCopy should match snapshot (auto-generated) 1`] = `
1414
class="pf-v5-c-form-control"
1515
>
1616
<input
17+
aria-expanded="false"
1718
aria-invalid="false"
1819
aria-label="'Copyable input'"
1920
data-ouia-component-id="OUIA-Generated-TextInputBase-1"

packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ exports[`With popover opened 1`] = `
1919
class="pf-v5-c-form-control"
2020
>
2121
<input
22+
aria-expanded="false"
2223
aria-invalid="false"
2324
aria-label="Date picker"
2425
data-ouia-component-id="OUIA-Generated-TextInputBase-4"
@@ -169,6 +170,7 @@ exports[`With popover opened 1`] = `
169170
class="pf-v5-c-form-control"
170171
>
171172
<input
173+
aria-expanded="false"
172174
aria-invalid="false"
173175
aria-label="Select year"
174176
data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -793,6 +795,7 @@ exports[`disabled date picker 1`] = `
793795
class="pf-v5-c-form-control pf-m-disabled"
794796
>
795797
<input
798+
aria-expanded="false"
796799
aria-invalid="false"
797800
aria-label="disabled date picker"
798801
data-ouia-component-id="OUIA-Generated-TextInputBase-1"

packages/react-core/src/components/FileUpload/__tests__/__snapshots__/FileUpload.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ exports[`simple fileupload 1`] = `
2020
>
2121
<input
2222
aria-describedby="simple-text-file-browse-button"
23+
aria-expanded="false"
2324
aria-invalid="false"
2425
aria-label="Drag a file here or browse to upload"
2526
data-ouia-component-id="OUIA-Generated-TextInputBase-1"

packages/react-core/src/components/FileUpload/__tests__/__snapshots__/FileUploadField.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ exports[`simple fileuploadfield 1`] = `
1919
>
2020
<input
2121
aria-describedby="custom-file-upload-browse-button"
22+
aria-expanded="false"
2223
aria-invalid="false"
2324
aria-label="Do something custom with this!"
2425
data-ouia-component-id="OUIA-Generated-TextInputBase-1"

packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ exports[`LoginForm LoginForm with rememberMeLabel 1`] = `
3737
class="pf-v5-c-form-control"
3838
>
3939
<input
40+
aria-expanded="false"
4041
aria-invalid="false"
4142
data-ouia-component-id="OUIA-Generated-TextInputBase-9"
4243
data-ouia-component-type="PF5/TextInput"
@@ -81,6 +82,7 @@ exports[`LoginForm LoginForm with rememberMeLabel 1`] = `
8182
class="pf-v5-c-form-control"
8283
>
8384
<input
85+
aria-expanded="false"
8486
aria-invalid="false"
8587
data-ouia-component-id="OUIA-Generated-TextInputBase-10"
8688
data-ouia-component-type="PF5/TextInput"
@@ -184,6 +186,7 @@ exports[`LoginForm LoginForm with show password 1`] = `
184186
class="pf-v5-c-form-control"
185187
>
186188
<input
189+
aria-expanded="false"
187190
aria-invalid="false"
188191
data-ouia-component-id="OUIA-Generated-TextInputBase-11"
189192
data-ouia-component-type="PF5/TextInput"
@@ -234,6 +237,7 @@ exports[`LoginForm LoginForm with show password 1`] = `
234237
class="pf-v5-c-form-control"
235238
>
236239
<input
240+
aria-expanded="false"
237241
aria-invalid="false"
238242
data-ouia-component-id="OUIA-Generated-TextInputBase-12"
239243
data-ouia-component-type="PF5/TextInput"
@@ -339,6 +343,7 @@ exports[`LoginForm should render Login form 1`] = `
339343
class="pf-v5-c-form-control"
340344
>
341345
<input
346+
aria-expanded="false"
342347
aria-invalid="false"
343348
data-ouia-component-id="OUIA-Generated-TextInputBase-1"
344349
data-ouia-component-type="PF5/TextInput"
@@ -383,6 +388,7 @@ exports[`LoginForm should render Login form 1`] = `
383388
class="pf-v5-c-form-control"
384389
>
385390
<input
391+
aria-expanded="false"
386392
aria-invalid="false"
387393
data-ouia-component-id="OUIA-Generated-TextInputBase-2"
388394
data-ouia-component-type="PF5/TextInput"

packages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ exports[`numberInput disables lower threshold 1`] = `
4747
class="pf-v5-c-form-control pf-m-readonly"
4848
>
4949
<input
50+
aria-expanded="false"
5051
aria-invalid="false"
5152
aria-label="Input"
5253
data-ouia-component-id="OUIA-Generated-TextInputBase-7"
@@ -140,6 +141,7 @@ exports[`numberInput disables upper threshold 1`] = `
140141
class="pf-v5-c-form-control pf-m-readonly"
141142
>
142143
<input
144+
aria-expanded="false"
143145
aria-invalid="false"
144146
aria-label="Input"
145147
data-ouia-component-id="OUIA-Generated-TextInputBase-8"
@@ -235,6 +237,7 @@ exports[`numberInput passes button props successfully 1`] = `
235237
class="pf-v5-c-form-control pf-m-readonly"
236238
>
237239
<input
240+
aria-expanded="false"
238241
aria-invalid="false"
239242
aria-label="Input"
240243
data-ouia-component-id="OUIA-Generated-TextInputBase-13"
@@ -329,6 +332,7 @@ exports[`numberInput passes input props successfully 1`] = `
329332
class="pf-v5-c-form-control"
330333
>
331334
<input
335+
aria-expanded="false"
332336
aria-invalid="false"
333337
aria-label="Input"
334338
data-ouia-component-id="OUIA-Generated-TextInputBase-12"
@@ -423,6 +427,7 @@ exports[`numberInput renders custom width 1`] = `
423427
class="pf-v5-c-form-control pf-m-readonly"
424428
>
425429
<input
430+
aria-expanded="false"
426431
aria-invalid="false"
427432
aria-label="Input"
428433
data-ouia-component-id="OUIA-Generated-TextInputBase-11"
@@ -517,6 +522,7 @@ exports[`numberInput renders defaults & extra props 1`] = `
517522
class="pf-v5-c-form-control pf-m-readonly"
518523
>
519524
<input
525+
aria-expanded="false"
520526
aria-invalid="false"
521527
aria-label="Input"
522528
data-ouia-component-id="OUIA-Generated-TextInputBase-1"
@@ -611,6 +617,7 @@ exports[`numberInput renders disabled 1`] = `
611617
class="pf-v5-c-form-control pf-m-readonly pf-m-disabled"
612618
>
613619
<input
620+
aria-expanded="false"
614621
aria-invalid="false"
615622
aria-label="Input"
616623
data-ouia-component-id="OUIA-Generated-TextInputBase-6"
@@ -706,6 +713,7 @@ exports[`numberInput renders error validated 1`] = `
706713
class="pf-v5-c-form-control pf-m-readonly pf-m-error"
707714
>
708715
<input
716+
aria-expanded="false"
709717
aria-invalid="true"
710718
aria-label="Input"
711719
data-ouia-component-id="OUIA-Generated-TextInputBase-3"
@@ -820,6 +828,7 @@ exports[`numberInput renders success validated 1`] = `
820828
class="pf-v5-c-form-control pf-m-readonly pf-m-success"
821829
>
822830
<input
831+
aria-expanded="false"
823832
aria-invalid="false"
824833
aria-label="Input"
825834
data-ouia-component-id="OUIA-Generated-TextInputBase-2"
@@ -939,6 +948,7 @@ exports[`numberInput renders unit & position 1`] = `
939948
class="pf-v5-c-form-control pf-m-readonly"
940949
>
941950
<input
951+
aria-expanded="false"
942952
aria-invalid="false"
943953
aria-label="Input"
944954
data-ouia-component-id="OUIA-Generated-TextInputBase-10"
@@ -1032,6 +1042,7 @@ exports[`numberInput renders unit 1`] = `
10321042
class="pf-v5-c-form-control pf-m-readonly"
10331043
>
10341044
<input
1045+
aria-expanded="false"
10351046
aria-invalid="false"
10361047
aria-label="Input"
10371048
data-ouia-component-id="OUIA-Generated-TextInputBase-9"
@@ -1130,6 +1141,7 @@ exports[`numberInput renders value 1`] = `
11301141
class="pf-v5-c-form-control pf-m-readonly"
11311142
>
11321143
<input
1144+
aria-expanded="false"
11331145
aria-invalid="false"
11341146
aria-label="Input"
11351147
data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -1223,6 +1235,7 @@ exports[`numberInput renders warning validated 1`] = `
12231235
class="pf-v5-c-form-control pf-m-readonly pf-m-warning"
12241236
>
12251237
<input
1238+
aria-expanded="false"
12261239
aria-invalid="false"
12271240
aria-label="Input"
12281241
data-ouia-component-id="OUIA-Generated-TextInputBase-4"

packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/Navigation.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ exports[`Navigation should match snapshot (auto-generated) 1`] = `
7575
class="pf-v5-c-form-control"
7676
>
7777
<input
78+
aria-expanded="false"
7879
aria-invalid="false"
7980
aria-label="Current page"
8081
data-ouia-component-id="OUIA-Generated-TextInputBase-1"

packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ exports[`Pagination API verify inset2xl inset breakpoints 1`] = `
134134
class="pf-v5-c-form-control"
135135
>
136136
<input
137+
aria-expanded="false"
137138
aria-invalid="false"
138139
aria-label="Current page"
139140
data-ouia-component-id="OUIA-Generated-TextInputBase-45"
@@ -342,6 +343,7 @@ exports[`Pagination API verify insetLg inset breakpoints 1`] = `
342343
class="pf-v5-c-form-control"
343344
>
344345
<input
346+
aria-expanded="false"
345347
aria-invalid="false"
346348
aria-label="Current page"
347349
data-ouia-component-id="OUIA-Generated-TextInputBase-43"
@@ -550,6 +552,7 @@ exports[`Pagination API verify insetMd inset breakpoints 1`] = `
550552
class="pf-v5-c-form-control"
551553
>
552554
<input
555+
aria-expanded="false"
553556
aria-invalid="false"
554557
aria-label="Current page"
555558
data-ouia-component-id="OUIA-Generated-TextInputBase-42"
@@ -758,6 +761,7 @@ exports[`Pagination API verify insetNone inset breakpoints 1`] = `
758761
class="pf-v5-c-form-control"
759762
>
760763
<input
764+
aria-expanded="false"
761765
aria-invalid="false"
762766
aria-label="Current page"
763767
data-ouia-component-id="OUIA-Generated-TextInputBase-40"
@@ -966,6 +970,7 @@ exports[`Pagination API verify insetSm inset breakpoints 1`] = `
966970
class="pf-v5-c-form-control"
967971
>
968972
<input
973+
aria-expanded="false"
969974
aria-invalid="false"
970975
aria-label="Current page"
971976
data-ouia-component-id="OUIA-Generated-TextInputBase-41"
@@ -1174,6 +1179,7 @@ exports[`Pagination API verify insetXl inset breakpoints 1`] = `
11741179
class="pf-v5-c-form-control"
11751180
>
11761181
<input
1182+
aria-expanded="false"
11771183
aria-invalid="false"
11781184
aria-label="Current page"
11791185
data-ouia-component-id="OUIA-Generated-TextInputBase-44"
@@ -1368,6 +1374,7 @@ exports[`Pagination component render custom pagination toggle 1`] = `
13681374
class="pf-v5-c-form-control"
13691375
>
13701376
<input
1377+
aria-expanded="false"
13711378
aria-invalid="false"
13721379
aria-label="Current page"
13731380
data-ouia-component-id="OUIA-Generated-TextInputBase-13"
@@ -1580,6 +1587,7 @@ exports[`Pagination component render custom perPageOptions 1`] = `
15801587
class="pf-v5-c-form-control"
15811588
>
15821589
<input
1590+
aria-expanded="false"
15831591
aria-invalid="false"
15841592
aria-label="Current page"
15851593
data-ouia-component-id="OUIA-Generated-TextInputBase-9"
@@ -1790,6 +1798,7 @@ exports[`Pagination component render custom start end 1`] = `
17901798
class="pf-v5-c-form-control"
17911799
>
17921800
<input
1801+
aria-expanded="false"
17931802
aria-invalid="false"
17941803
aria-label="Current page"
17951804
data-ouia-component-id="OUIA-Generated-TextInputBase-11"
@@ -1959,6 +1968,7 @@ exports[`Pagination component render empty per page options 1`] = `
19591968
class="pf-v5-c-form-control"
19601969
>
19611970
<input
1971+
aria-expanded="false"
19621972
aria-invalid="false"
19631973
aria-label="Current page"
19641974
data-ouia-component-id="OUIA-Generated-TextInputBase-10"
@@ -2169,6 +2179,7 @@ exports[`Pagination component render last page 1`] = `
21692179
class="pf-v5-c-form-control"
21702180
>
21712181
<input
2182+
aria-expanded="false"
21722183
aria-invalid="false"
21732184
aria-label="Current page"
21742185
data-ouia-component-id="OUIA-Generated-TextInputBase-8"
@@ -2383,6 +2394,7 @@ exports[`Pagination component render limited number of pages 1`] = `
23832394
class="pf-v5-c-form-control pf-m-disabled"
23842395
>
23852396
<input
2397+
aria-expanded="false"
23862398
aria-invalid="false"
23872399
aria-label="Current page"
23882400
data-ouia-component-id="OUIA-Generated-TextInputBase-6"
@@ -2586,6 +2598,7 @@ exports[`Pagination component render should render correctly bottom 1`] = `
25862598
class="pf-v5-c-form-control"
25872599
>
25882600
<input
2601+
aria-expanded="false"
25892602
aria-invalid="false"
25902603
aria-label="Current page"
25912604
data-ouia-component-id="OUIA-Generated-TextInputBase-2"
@@ -2786,6 +2799,7 @@ exports[`Pagination component render should render correctly bottom sticky 1`] =
27862799
class="pf-v5-c-form-control"
27872800
>
27882801
<input
2802+
aria-expanded="false"
27892803
aria-invalid="false"
27902804
aria-label="Current page"
27912805
data-ouia-component-id="OUIA-Generated-TextInputBase-4"
@@ -3130,6 +3144,7 @@ exports[`Pagination component render should render correctly disabled 1`] = `
31303144
class="pf-v5-c-form-control pf-m-disabled"
31313145
>
31323146
<input
3147+
aria-expanded="false"
31333148
aria-invalid="false"
31343149
aria-label="Current page"
31353150
data-ouia-component-id="OUIA-Generated-TextInputBase-5"
@@ -3345,6 +3360,7 @@ exports[`Pagination component render should render correctly sticky 1`] = `
33453360
class="pf-v5-c-form-control"
33463361
>
33473362
<input
3363+
aria-expanded="false"
33483364
aria-invalid="false"
33493365
aria-label="Current page"
33503366
data-ouia-component-id="OUIA-Generated-TextInputBase-3"
@@ -3557,6 +3573,7 @@ exports[`Pagination component render should render correctly top 1`] = `
35573573
class="pf-v5-c-form-control"
35583574
>
35593575
<input
3576+
aria-expanded="false"
35603577
aria-invalid="false"
35613578
aria-label="Current page"
35623579
data-ouia-component-id="OUIA-Generated-TextInputBase-1"
@@ -3769,6 +3786,7 @@ exports[`Pagination component render titles 1`] = `
37693786
class="pf-v5-c-form-control"
37703787
>
37713788
<input
3789+
aria-expanded="false"
37723790
aria-invalid="false"
37733791
aria-label="Current page"
37743792
data-ouia-component-id="OUIA-Generated-TextInputBase-12"
@@ -3981,6 +3999,7 @@ exports[`Pagination component render up drop direction 1`] = `
39813999
class="pf-v5-c-form-control"
39824000
>
39834001
<input
4002+
aria-expanded="false"
39844003
aria-invalid="false"
39854004
aria-label="Current page"
39864005
data-ouia-component-id="OUIA-Generated-TextInputBase-14"
@@ -4193,6 +4212,7 @@ exports[`Pagination component render zero results 1`] = `
41934212
class="pf-v5-c-form-control pf-m-disabled"
41944213
>
41954214
<input
4215+
aria-expanded="false"
41964216
aria-invalid="false"
41974217
aria-label="Current page"
41984218
data-ouia-component-id="OUIA-Generated-TextInputBase-7"

packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
333333
class="pf-v5-c-form-control"
334334
>
335335
<input
336+
aria-expanded="false"
336337
aria-invalid="false"
337338
data-ouia-component-id="OUIA-Generated-TextInputBase-1"
338339
data-ouia-component-type="PF5/TextInput"
@@ -369,6 +370,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
369370
class="pf-v5-c-form-control"
370371
>
371372
<input
373+
aria-expanded="false"
372374
aria-invalid="false"
373375
data-ouia-component-id="OUIA-Generated-TextInputBase-2"
374376
data-ouia-component-type="PF5/TextInput"
@@ -405,6 +407,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
405407
class="pf-v5-c-form-control"
406408
>
407409
<input
410+
aria-expanded="false"
408411
aria-invalid="false"
409412
data-ouia-component-id="OUIA-Generated-TextInputBase-3"
410413
data-ouia-component-type="PF5/TextInput"

0 commit comments

Comments
 (0)