Skip to content

Commit 86b53c4

Browse files
committed
refactor fix
1 parent 2f43f7c commit 86b53c4

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

spec/ParseFile.spec.js

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -624,25 +624,37 @@ describe('Parse.File testing', () => {
624624
});
625625

626626
describe('getting files', () => {
627-
it('can get invalid file', async () => {
627+
it('does not crash on file request with invalid app ID', async () => {
628628
const res1 = await request({
629629
url: 'http://localhost:8378/1/files/invalid-id/invalid-file.txt',
630630
}).catch(e => e);
631631
expect(res1.status).toBe(403);
632632
expect(res1.data).toEqual({ code: 119, error: 'Invalid application ID.' });
633-
// Check whether server did not crash
633+
// Ensure server did not crash
634634
const res2 = await request({ url: 'http://localhost:8378/1/health' });
635635
expect(res2.status).toEqual(200);
636636
expect(res2.data).toEqual({ status: 'ok' });
637637
});
638638

639-
it('can get invalid metadata', async () => {
639+
it('does not crash on file request with invalid path', async () => {
640+
const res1 = await request({
641+
url: 'http://localhost:8378/1/files/invalid-id//invalid-path/%20/invalid-file.txt',
642+
}).catch(e => e);
643+
expect(res1.status).toBe(403);
644+
expect(res1.data).toEqual({ error: 'unauthorized' });
645+
// Ensure server did not crash
646+
const res2 = await request({ url: 'http://localhost:8378/1/health' });
647+
expect(res2.status).toEqual(200);
648+
expect(res2.data).toEqual({ status: 'ok' });
649+
});
650+
651+
it('does not crash on file metadata request with invalid app ID', async () => {
640652
const res1 = await request({
641653
url: `http://localhost:8378/1/files/invalid-id/metadata/invalid-file.txt`,
642654
});
643655
expect(res1.status).toBe(200);
644656
expect(res1.data).toEqual({});
645-
// Check whether server did not crash
657+
// Ensure server did not crash
646658
const res2 = await request({ url: 'http://localhost:8378/1/health' });
647659
expect(res2.status).toEqual(200);
648660
expect(res2.data).toEqual({ status: 'ok' });

0 commit comments

Comments
 (0)