fix: keep rows visible above footer

mtrezza · mtrezza · commit 1b453fea3ab5 · 2025-07-09T16:06:51.000+02:00
diff --git a/src/components/BrowserCell/BrowserCell.react.js b/src/components/BrowserCell/BrowserCell.react.js
@@ -235,10 +235,12 @@ export default class BrowserCell extends Component {
 
         // BrowserToolbar + DataBrowserHeader height
         const topBoundary = 126;
+        // Account for BrowserFooter height when checking the bottom boundary
+        const bottomBoundary = window.innerHeight - 36;
 
         if (left < leftBoundary || right > window.innerWidth) {
           node.scrollIntoView({ block: 'nearest', inline: 'start' });
-        } else if (top < topBoundary || bottom > window.innerHeight) {
+        } else if (top < topBoundary || bottom > bottomBoundary) {
           node.scrollIntoView({ block: 'nearest', inline: 'nearest' });
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -235,10 +235,12 @@ export default class BrowserCell extends Component {`
`235`	`235`
`236`	`236`	`// BrowserToolbar + DataBrowserHeader height`
`237`	`237`	`const topBoundary = 126;`
	`238`	`+ // Account for BrowserFooter height when checking the bottom boundary`
	`239`	`+ const bottomBoundary = window.innerHeight - 36;`
`238`	`240`
`239`	`241`	`if (left < leftBoundary \|\| right > window.innerWidth) {`
`240`	`242`	`node.scrollIntoView({ block: 'nearest', inline: 'start' });`
`241`		`- } else if (top < topBoundary \|\| bottom > window.innerHeight) {`
	`243`	`+ } else if (top < topBoundary \|\| bottom > bottomBoundary) {`
`242`	`244`	`node.scrollIntoView({ block: 'nearest', inline: 'nearest' });`
`243`	`245`	`}`
`244`	`246`	`}`