v2.4.0 release

* adds local monomod, uses HarmonyPrerelease flag to use it

* switch submodule monomod to branch 'merge-reorganize-arm64'

* wip

* updates to fixes in monomod prerelease

* 2.3.7-prerelease

* adds recursive checkout to github platform tests

* fix indention of previous commit

* adds arm64 test

* debug special case failure

* handle try/fault with try/catch/finally logic

* remove debugging

* uses local monomod

* bump version

* increase timeout for MacOS-arm64 .NET/Mono

* more timeout bumping

* 45min max timeout should be enough

* ci test changes

* switch back to recursive submodule checkout

* don't run twice on PRs

* test: submodule MonoMod -> upstream reorganize 23e6a19f

* Restore IL offset logging

* fixes harmony logging il offsets and adds tests for it

Author: pardeike

.github/actions/test-build-cache/action.yml

@@ -15,5 +15,6 @@ runs:
     - name: Download Build Cache
       uses: actions/download-artifact@v4
       with:
-        name: build-output-${{inputs.os}}-${{inputs.build_configuration}}
+        pattern: build-output-${{inputs.os}}-${{inputs.build_configuration}}*
         path: HarmonyTests/bin/
+        merge-multiple: true

.github/actions/test-execute-test/action.yml

@@ -95,7 +95,7 @@ runs:
       uses: nick-fields/retry@v3
       if: ${{inputs.os == 'macos' || inputs.os == 'macos-arm64'}}
       with:
-        timeout_minutes: 3
+        timeout_minutes: 45
         max_attempts: 3
         retry_on: timeout
         command: |

.github/actions/test-upload-result/action.yml

@@ -32,3 +32,4 @@ runs:
         name: ${{(inputs.experimental == 'true' && 'experimental-') || ''}}test-results-${{inputs.runtime-type}}-${{inputs.os}}-${{inputs.architecture}}-${{inputs.target_framework}}-${{inputs.build_configuration}}
         path: '**/*.trx'
         if-no-files-found: ${{(inputs.experimental == 'true' && 'ignore') || 'warn'}}
+        compression-level: 0

.github/workflows/test-build.yml

@@ -43,6 +43,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Setup .NET
         uses: actions/setup-dotnet@v4

.github/workflows/test-qemu-dotnet.yml

@@ -42,6 +42,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Download Build Cache
         uses: ./.github/actions/test-build-cache
@@ -69,14 +71,15 @@ jobs:
           dockerRunArgs: |
             --volume "${PWD}/src:/src"
           install: |
-            apt-get update
-            apt-get install -y wget libc6 libgcc-s1 libgssapi-krb5-2 libicu70 liblttng-ust1 libssl3 libstdc++6 libunwind8 zlib1g
-       
-            wget https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh;
-            chmod +x dotnet-install.sh;
-            ./dotnet-install.sh --channel LTS --no-path > /dev/null;
-            ./dotnet-install.sh --channel STS --no-path > /dev/null;
-            ./dotnet-install.sh --channel ${{steps.get_channel.outputs.channel}} --no-path > /dev/null;
+            apt-get -yqq update
+            apt-get -yqq install --no-install-recommends \
+              wget libc6 libgcc-s1 libgssapi-krb5-2 libicu70 liblttng-ust1 libssl3 libstdc++6 libunwind8 zlib1g
+            rm -rf /var/lib/apt/lists/*
+
+            wget -q https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh
+            chmod +x dotnet-install.sh
+            # Install only the required channel computed above; avoid redundant LTS/STS installs.
+            ./dotnet-install.sh --channel ${{steps.get_channel.outputs.channel}} --no-path > /dev/null
           run: |
             LD_LIBRARY_PATH="/usr/local/lib"  /root/.dotnet/dotnet test "HarmonyTests/bin/${{inputs.build_configuration}}/${{inputs.target_framework}}/HarmonyTests.dll" -f ${{inputs.target_framework}} -l trx -l "console;verbosity=normal" --blame -- ${{inputs.run_settings_args}};
 

.github/workflows/test-qemu-mono.yml

@@ -42,6 +42,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Download Build Cache
         uses: ./.github/actions/test-build-cache
@@ -63,9 +65,11 @@ jobs:
           dockerRunArgs: |
             --volume "${PWD}/src:/src"
           install: |
-            apt-get update
-            apt-get install -y wget libc6 libgcc-s1 libgssapi-krb5-2 libicu70 liblttng-ust1 libssl3 libstdc++6 libunwind8 zlib1g mono-devel
-            
+            apt-get -yqq update
+            apt-get -yqq install --no-install-recommends \
+              wget libc6 libgcc-s1 libgssapi-krb5-2 libicu70 liblttng-ust1 libssl3 libstdc++6 libunwind8 zlib1g mono-devel
+            rm -rf /var/lib/apt/lists/*
+
             wget https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh;
             chmod +x dotnet-install.sh;
             ./dotnet-install.sh --channel LTS --no-path > /dev/null;

.github/workflows/test-result-upload.yml

@@ -16,12 +16,15 @@ jobs:
     timeout-minutes: 5
     steps:
       - uses: actions/checkout@v4
-     
+        with:
+          submodules: recursive
+
       - name: Download Test Results
         uses: actions/download-artifact@v4
         with:
           pattern: ${{(inputs.experimental && 'experimental-') || ''}}test-results-*
           path: test-results
+          merge-multiple: true
 
       - name: Publish Test Results
         uses: EnricoMi/publish-unit-test-result-action@v2

.github/workflows/test-unix-dotnet.yml

@@ -56,9 +56,11 @@ jobs:
     name: ${{inputs.build_configuration}}
     runs-on: ${{inputs.image}}
     continue-on-error: ${{inputs.experimental}}
-    timeout-minutes: 10
+    timeout-minutes: 45
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Install Rosetta 2 on macOS
         if: ${{inputs.image == 'macos-14' && inputs.architecture == 'x64'}}
@@ -81,7 +83,8 @@ jobs:
           target_framework: ${{inputs.target_framework}}
           target_framework_array: ${{inputs.target_framework_array}}
 
-      - name: Get Installed .NET Sdk Information
+      - name: Dotnet info (only if previous steps failed)
+        if: ${{ failure() }}
         run: dotnet --info
         shell: pwsh
 

.github/workflows/test-unix-mono.yml

@@ -59,6 +59,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Install Rosetta 2 on macOS
         if: ${{ inputs.image == 'macos-14' && inputs.architecture == 'x64' }}

.github/workflows/test-windows-dotnet.yml

@@ -51,6 +51,8 @@ jobs:
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Setup .NET Latest/${{inputs.target_framework}} ${{inputs.architecture}}
         uses: ./.github/actions/test-setup-dotnet-windows
@@ -68,7 +70,7 @@ jobs:
         with:
           os: windows
           build_configuration: ${{inputs.build_configuration}}
-          
+
       - name: Test .NET ${{inputs.architecture}}
         uses: ./.github/actions/test-execute-test
         with: