Revert "opt: reduce atomic operations for asynchronous task queues in pollers"

This reverts commit 90bea0e.

Author: panjf2000

internal/netpoll/epoll_default_poller.go

@@ -178,11 +178,10 @@ func (p *Poller) Polling(callback func(fd int, ev uint32) error) error {
 				}
 				queue.PutTask(task)
 			}
+			atomic.StoreInt32(&p.netpollWakeSig, 0)
 			if !p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty() {
 				for _, err = unix.Write(p.wfd, b); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Write(p.wfd, b) {
 				}
-			} else {
-				atomic.StoreInt32(&p.netpollWakeSig, 0)
 			}
 		}
 

internal/netpoll/epoll_optimized_poller.go

@@ -180,11 +180,10 @@ func (p *Poller) Polling() error {
 				}
 				queue.PutTask(task)
 			}
+			atomic.StoreInt32(&p.netpollWakeSig, 0)
 			if !p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty() {
 				for _, err = unix.Write(p.wpa.FD, b); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Write(p.wpa.FD, b) {
 				}
-			} else {
-				atomic.StoreInt32(&p.netpollWakeSig, 0)
 			}
 		}
 

internal/netpoll/kqueue_default_poller.go

@@ -176,11 +176,10 @@ func (p *Poller) Polling(callback func(fd int, filter int16) error) error {
 				}
 				queue.PutTask(task)
 			}
+			atomic.StoreInt32(&p.netpollWakeSig, 0)
 			if !p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty() {
 				for _, err = unix.Kevent(p.fd, wakeChanges, nil, nil); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Kevent(p.fd, wakeChanges, nil, nil) {
 				}
-			} else {
-				atomic.StoreInt32(&p.netpollWakeSig, 0)
 			}
 		}
 

internal/netpoll/kqueue_optimized_poller.go

@@ -177,11 +177,10 @@ func (p *Poller) Polling() error {
 				}
 				queue.PutTask(task)
 			}
+			atomic.StoreInt32(&p.netpollWakeSig, 0)
 			if !p.asyncTaskQueue.Empty() || !p.priorAsyncTaskQueue.Empty() {
 				for _, err = unix.Kevent(p.fd, wakeChanges, nil, nil); err == unix.EINTR || err == unix.EAGAIN; _, err = unix.Kevent(p.fd, wakeChanges, nil, nil) {
 				}
-			} else {
-				atomic.StoreInt32(&p.netpollWakeSig, 0)
 			}
 		}