Skip to content

DEP/CI: Pin flake8-rst version #23699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 14, 2018

Pins version of flake8-rst to 0.4.2.

  • Newer versions of this plugin will cover more code-blocks within the documentation. Thus CI will fail when new version is released to conda-forge.
  • Devs using pip already get issues as version 0.4.3 is released to PyPI.

flake8-rst is getting upgraded shortly to a version >0.4.3. I'm currently updating the doc so it becomes compliant with that newer version, therefore I don't open issues to fix the doc for version 0.4.3.

Signed-off-by: Fabian Haase <[email protected]>
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #23699 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23699   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51340    51340           
=======================================
  Hits        47361    47361           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4405d...017f0f8. Read the comment docs.

@jreback jreback added Docs CI Continuous Integration labels Nov 14, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 14, 2018
@jreback jreback merged commit a6c71bf into pandas-dev:master Nov 14, 2018
@jreback
Copy link
Contributor

jreback commented Nov 14, 2018

thanks @FHaase

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@FHaase FHaase deleted the pin-flake8_rst-version branch November 22, 2018 20:52
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8-rst 0.4.3 config?
2 participants